Skip to content
This repository has been archived by the owner on Jan 29, 2020. It is now read-only.

Commit

Permalink
Merge branch 'master' into dev-filefilessize
Browse files Browse the repository at this point in the history
  • Loading branch information
bgotink committed Dec 25, 2014
157 parents df35d8a + c0d4707 + fb9dce0 + c45b896 + 739e942 + 29a4517 + 3179585 + ae205d0 + 6d3ab5a + 5b7a64f + 7591112 + 7610b9a + f91c471 + acef74d + d753e94 + 7a829bf + 3b93376 + 6c2eca4 + 48bc01e + 3c88cd5 + fbfc750 + 441b9de + b57e2b9 + 2beef92 + 3ae4add + 994832b + 6db3cde + e0f83ee + 712223d + 3b4ec35 + e53a267 + 51bf3c7 + 10a1e95 + 30ee303 + 96417b9 + 50ea13f + 24d1c0c + b09295e + 13758aa + 99316f8 + 40b8ac3 + e284e0b + 8ff51b4 + 4b5ea1e + 5b24371 + ed932b6 + 357852d + 262e5d6 + 9057a3f + 0e1e846 + 5d11876 + 0ae0984 + 6ff135c + 0b45aba + 1778b0c + a574713 + ba3f132 + 56365a6 + 019f89a + b09b3ba + 2af32d0 + cb39fc7 + 3f8a6fd + 8999753 + a7cd86b + da1c469 + 5371cdb + fd9f625 + 99d3fcd + 1e3ed17 + a360459 + 1a1e9aa + 4c8955c + 94f2feb + 5b450ef + e64e5b0 + e9d19a6 + a5a9b6e + 5e59c3a + a47f2db + 3cf915a + a2a5c91 + 1cd3439 + ef9c643 + 298a619 + 001ae99 + c37ab8e + 017f6f1 + 0711f77 + 38af804 + 23120b4 + 5f96f53 + a257169 + 8085bc4 + 3110cd4 + f270d41 + 9536f09 + 4ec1292 + adcdd78 + e80fff6 + 99fc5ce + 1d23e94 + fa167cb + a93e92f + 13a2df8 + 06689fb + 2d601eb + 72a3295 + a59f42c + 0f4489d + b3f7029 + 3c492ce + 259bcdc + a811ae5 + f66f985 + 173e949 + b93077e + f11a10d + 5ac4be0 + cb31aff + d34bdbb + 725b978 + 27b423e + 624ac5e + a3340ac + 80ab2e3 + 3429053 + 998a6d7 + 8b9ab71 + d4dffb0 + 5456435 + 97180fa + 126be7f + c16eb72 + 8ccb096 + 50481b9 + 411738a + 50b5c0b + 0721376 + ca3399f + 5abf474 + 7783b57 + a53deb5 + c8885be + 1adf3e3 + 5a45e41 + 3370b44 + b4caa32 + 2a7fc79 + 755e064 + fde42e0 + fb9bce8 + 3ff447c + 7cbed25 + 61aff3c + a27b9cd + d776971 commit 3a02933
Show file tree
Hide file tree
Showing 16 changed files with 9 additions and 29 deletions.
2 changes: 0 additions & 2 deletions src/Adapter/AbstractAdapter.php
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,6 @@ public function writeBox(
// Draw vertical lines and fill
if (is_numeric($fillStyle)
&& $fillStyle !== static::FILL_NONE) {

switch ($fillStyle) {
case static::FILL_SHADE_LIGHT:
$fillChar = $charset::SHADE_LIGHT;
Expand All @@ -210,7 +209,6 @@ public function writeBox(
$fillChar = $charset::BLOCK;
break;
}

} elseif ($fillStyle) {
$fillChar = StringUtils::getWrapper()->substr($fillStyle, 0, 1);
} else {
Expand Down
1 change: 0 additions & 1 deletion src/Charset/Ascii.php
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
*/
class Ascii implements CharsetInterface
{

const ACTIVATE = "";
const DEACTIVATE = "";

Expand Down
1 change: 0 additions & 1 deletion src/Charset/AsciiExtended.php
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
*/
class AsciiExtended implements CharsetInterface
{

const ACTIVATE = "";
const DEACTIVATE = "";

Expand Down
1 change: 0 additions & 1 deletion src/Charset/DECSG.php
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
*/
class DECSG implements CharsetInterface
{

const ACTIVATE = "\x1b(0";
const DEACTIVATE = "\x1b(B";

Expand Down
1 change: 0 additions & 1 deletion src/Charset/Utf8.php
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
*/
class Utf8 implements CharsetInterface
{

const ACTIVATE = "";
const DEACTIVATE = "";

Expand Down
1 change: 0 additions & 1 deletion src/Charset/Utf8Heavy.php
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
*/
class Utf8Heavy extends Utf8
{

const LINE_SINGLE_EW = "";
const LINE_SINGLE_NS = "";
const LINE_SINGLE_NW = "";
Expand Down
1 change: 0 additions & 1 deletion src/Exception/BadMethodCallException.php
Original file line number Diff line number Diff line change
Expand Up @@ -11,5 +11,4 @@

class BadMethodCallException extends \BadMethodCallException implements ExceptionInterface
{

}
1 change: 0 additions & 1 deletion src/Getopt.php
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,6 @@
*/
class Getopt
{

/**
* The options for a given application can be in multiple formats.
* modeGnu is for traditional 'ab:c:' style getopt format.
Expand Down
1 change: 0 additions & 1 deletion src/Prompt/Char.php
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@ public function __construct(
$allowEmpty = false,
$echo = true
) {

$this->setPromptText($promptText);
$this->setAllowEmpty($allowEmpty);
$this->setIgnoreCase($ignoreCase);
Expand Down
1 change: 0 additions & 1 deletion src/Prompt/Select.php
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,6 @@ public function __construct(
if ($echo !== null) {
$this->setEcho($echo);
}

}

/**
Expand Down
1 change: 0 additions & 1 deletion src/Response.php
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@

class Response extends Message implements ResponseInterface
{

/**
* @var bool
*/
Expand Down
1 change: 0 additions & 1 deletion src/RouteMatcher/DefaultRouteMatcher.php
Original file line number Diff line number Diff line change
Expand Up @@ -728,7 +728,6 @@ public function match($params)
* Advance to next argument
*/
$argPos++;

}

/*
Expand Down
2 changes: 0 additions & 2 deletions src/RouteMatcher/RouteMatcherInterface.php
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,11 @@

interface RouteMatcherInterface
{

/**
* Match parameters against route passed to constructor
*
* @param array $params
* @return array|null
*/
public function match($params);

}
16 changes: 8 additions & 8 deletions test/ConsoleTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -68,15 +68,15 @@ public function testCanNotGetInstanceInNoConsoleMode()

public function testCanForceInstance()
{
$console = Console::getInstance('Posix');
$this->assertTrue($console instanceof Adapter\AdapterInterface);
$this->assertTrue($console instanceof Adapter\Posix);
$console = Console::getInstance('Posix');
$this->assertTrue($console instanceof Adapter\AdapterInterface);
$this->assertTrue($console instanceof Adapter\Posix);

Console::overrideIsConsole(null);
Console::resetInstance();
Console::overrideIsConsole(null);
Console::resetInstance();

$console = Console::getInstance('Windows');
$this->assertTrue($console instanceof Adapter\AdapterInterface);
$this->assertTrue($console instanceof Adapter\Windows);
$console = Console::getInstance('Windows');
$this->assertTrue($console instanceof Adapter\AdapterInterface);
$this->assertTrue($console instanceof Adapter\Windows);
}
}
3 changes: 0 additions & 3 deletions test/GetoptTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,6 @@ public function testGetoptUsageMessageFromException()
$message = preg_replace('/ /', '_', $message);
$this->assertEquals($message,
"Usage:_<progname>_[_options_]\n--apple|-a_[_<string>_]_________________apple\n--banana1|--banana2|--banana3|--banana4_banana\n--pear_<string>_________________________pear\n");

}
}

Expand Down Expand Up @@ -342,7 +341,6 @@ public function testGetoptSetHelp()
$message = preg_replace('/ /', '_', $message);
$this->assertEquals($message,
"Usage:_<progname>_[_options_]\n-a___________________apple\n-b___________________banana\n-p_<string>__________pear\n");

}

public function testGetoptSetHelpInvalid()
Expand Down Expand Up @@ -408,7 +406,6 @@ public function testGetoptCheckParameterType()

$opts->setArguments(array('-k', 'string'));
$this->assertEquals('string', $opts->k);

}

/**
Expand Down
4 changes: 1 addition & 3 deletions test/RouteMatcher/DefaultRouteMatcherTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
*/
class DefaultRouteMatcherTest extends \PHPUnit_Framework_TestCase
{

public static function routeProvider()
{
return array(
Expand Down Expand Up @@ -1208,8 +1207,7 @@ public function testMatchingWithAliases(
array $aliases = array(),
array $arguments = array(),
array $params = null
)
{
) {
$route = new DefaultRouteMatcher($routeDefinition, array(), array(), $aliases);
$match = $route->match($arguments);

Expand Down

0 comments on commit 3a02933

Please sign in to comment.