Skip to content
This repository has been archived by the owner on Jan 29, 2020. It is now read-only.

drop PHP 5.4 check #1

Merged
merged 3 commits into from
Oct 21, 2015
Merged

drop PHP 5.4 check #1

merged 3 commits into from
Oct 21, 2015

Conversation

samsonasik
Copy link
Contributor

No description provided.

@samsonasik
Copy link
Contributor Author

rebased, should be merge-able now

@samsonasik
Copy link
Contributor Author

@mwillbanks merge-able ?

* htmlspecialchars(). We modify these for PHP 5.4 to take advantage
* of the new ENT_SUBSTITUTE flag for correctly dealing with invalid
* UTF-8 sequences.
* htmlspecialchars().
*
* @var string
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it actually a string?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be nullint ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably cannot be null, given the constructor structure

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, updated ;)

@Maks3w Maks3w self-assigned this Oct 21, 2015
@Maks3w Maks3w modified the milestones: 2.4.3, 2.5.2 Oct 21, 2015
Maks3w added a commit that referenced this pull request Oct 21, 2015
Maks3w added a commit that referenced this pull request Oct 21, 2015
@Maks3w Maks3w merged commit 88b2db8 into zendframework:master Oct 21, 2015
Maks3w added a commit that referenced this pull request Oct 21, 2015
@Maks3w Maks3w removed this from the 2.4.3 milestone Oct 21, 2015
@samsonasik samsonasik deleted the up-php branch October 21, 2015 12:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants