This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
Refactors to use a response factory instead of prototype #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates to use a response factory instead of a prototype. This alleviates the need for a stream factory, and allows re-use of the `ResponseInterface` service with Expressive v3. It also simplifies the constructors.
Removes unused dependencies (http-interop/http-middleware, zend-diactoros), and updates the zend-expressive-helpers dependency to require 5.0.0alpha3 or above (to ensure compatibility). To do so, it requires a minimum stability of alpha.
Also discovered a number of other general changes that were necessary: - Docs were still refering to http-interop; updated to PSR-15. - Docs were detailing middleware, where request handlers were more appropriate. - Docs were using http URIs for PHP-FIG links; updated to https. - Added more links to FIG specifications.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to use a response factory instead of a prototype. This alleviates the need for a stream factory, and allows re-use of the
ResponseInterfaceservice with Expressive v3. It also simplifies the constructors.TODO