Skip to content
This repository has been archived by the owner on Jan 29, 2020. It is now read-only.

Keep original query filters in collection self _links #36

Merged

Conversation

alextech
Copy link
Contributor

@alextech alextech commented Mar 28, 2018

Provide a narrative description of what you are trying to accomplish:

  • Are you fixing a bug?
    • Detail how the bug is invoked currently.
      Request collection with localhost:8080/clients/?radius=5
    • Detail the original, incorrect behavior.
      Filter parameters specified were lost on HAL generation. Output had no way to tell what filters produced the resultant collection
    • Detail the new, expected behavior.
      Output should keep filter parameters to be clear how the results were achieved.
    • Base your feature on the master branch, and submit against that branch.
    • Add a regression test that demonstrates the bug, and proves the fix.
    • Add a CHANGELOG.md entry for the fix.

@weierophinney weierophinney merged commit 2529382 into zendframework:master Mar 28, 2018
weierophinney added a commit that referenced this pull request Mar 28, 2018
Keep original query filters in collection self _links
weierophinney added a commit that referenced this pull request Mar 28, 2018
weierophinney added a commit that referenced this pull request Mar 28, 2018
weierophinney added a commit that referenced this pull request Mar 28, 2018
Forward port #36

Conflicts:
	CHANGELOG.md
@weierophinney
Copy link
Member

Thanks, @alextech!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants