This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
Generate a session id for new sessions with data #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/PhpSessionPersistence.php
Outdated
| // Regenerate if the session is marked as regenerated | ||
| // Regenerate if there is no cookie id set but the session has changed (new session with data) | ||
| if ($session->isRegenerated() | ||
| || ($session->hasChanged() && ! $this->cookie)) { |
There was a problem hiding this comment.
) { from if statement should be in new line
test/PhpSessionPersistenceTest.php
Outdated
| @@ -422,4 +422,30 @@ public function testPersistSessionReturnsExpectedResponseWithoutAddedCacheHeader | |||
|
|
|||
| $this->restoreOriginalSessionIniSettings($ini); | |||
| } | |||
|
|
|||
| public function testCookiesNotSetWithoutRegenerate(): void | |||
There was a problem hiding this comment.
Usually we are not adding : void in tests, but if we keep it here, there should be one space before : (consistency).
test/PhpSessionPersistenceTest.php
Outdated
| $response = new Response(); | ||
| $response = $persistence->persistSession($session, $response); | ||
|
|
||
| $this->assertEmpty($response->getHeaderLine('Set-Cookie')); |
There was a problem hiding this comment.
Maybe we can just check $this->assertFalse($response->hasHeader()) ?
|
Hello @xtreamwayz |
|
Incorporated changes from @webimpress and @pine3ree. |
src/PhpSessionPersistence.php
Outdated
| @@ -16,7 +15,6 @@ | |||
| use Zend\Expressive\Session\Session; | |||
| use Zend\Expressive\Session\SessionInterface; | |||
| use Zend\Expressive\Session\SessionPersistenceInterface; | |||
|
|
|||
There was a problem hiding this comment.
Revert this change, we should have an empty line between different type of imports.
weierophinney
added a commit
that referenced
this pull request
May 14, 2018
Generate a session id for new sessions with data
weierophinney
added a commit
that referenced
this pull request
May 14, 2018
weierophinney
added a commit
that referenced
this pull request
May 14, 2018
Forward port #21 Conflicts: CHANGELOG.md
|
Thanks, @xtreamwayz! |
jbelien
added a commit
to geo6/batch-geocoder
that referenced
this pull request
May 15, 2018
Issue with session creation is fixed. See zendframework/zend-expressive-session-ext#21
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a new session was generated, the session id isn't stored. On persistence it doesn't (re)generate an id which is expected. You only need a session if there is data to store. However there is never a check performed for changed data session.
This PR tries to fix that and checks if session data is changed and generates a session id if there wasn't one. This makes sure that data is stored if there wasn't a session yet.