Skip to content
This repository has been archived by the owner on Jan 29, 2020. It is now read-only.

parse boolean ini settings when creating the response cookie #40

Merged
merged 2 commits into from
Feb 28, 2019
Merged

parse boolean ini settings when creating the response cookie #40

merged 2 commits into from
Feb 28, 2019

Conversation

pine3ree
Copy link
Contributor

The imported SetCookie class does not perform type-checking, so a ini value Off would be considere a truthy value when setting secure and httpOnly values in the response cookies.

  • refactored the logic of set-cookie creation in a factory method
  • added test case + provider

@weierophinney weierophinney merged commit bc0edcb into zendframework:develop Feb 28, 2019
weierophinney added a commit that referenced this pull request Feb 28, 2019
@weierophinney
Merge pull request #40 from pine3ree/add-create-session-cookie
104cc1d 
parse boolean ini settings when creating the response cookie
weierophinney added a commit that referenced this pull request Feb 28, 2019
@weierophinney
Adds CHANGELOG entry for #40
fc052bd
@weierophinney
Copy link
Member

Thanks, @pine3ree!

@pine3ree pine3ree deleted the add-create-session-cookie branch February 28, 2019 18:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pine3ree @weierophinney