You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jan 21, 2020. It is now read-only.
Since this is a project skeleton shouldn't the composer recommendations be followed when the consumer of this repo decides to push it the his/her vsc?
I can understand from a maintainer point of view, of this repo, that it limits the possibility of a composer.lock file to be commit. But perhaps it should be included in the interactive install process to have it removed?
The text was updated successfully, but these errors were encountered:
Hi, @jonsa - Yes, having it in the repo is a bit of a problem, as it locks the installation to specific revisions, requiring users to immediately run a composer update to get new versions; this in turn creates maintenance overhead on our part, as we have to be constantly updating and pushing new tags of the skeleton whenever we release new versions of dependencies.
However, as you note, having an installation step that removes the composer.lock entry from the .gitignore file would work fine. Would you be willing to try and tackle that in a pull request?
Since this is a project skeleton shouldn't the composer recommendations be followed when the consumer of this repo decides to push it the his/her vsc?
I can understand from a maintainer point of view, of this repo, that it limits the possibility of a composer.lock file to be commit. But perhaps it should be included in the interactive install process to have it removed?
The text was updated successfully, but these errors were encountered: