This repository has been archived by the owner on Jan 21, 2020. It is now read-only.
It's time to add some test for the installer itself #48
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,65 @@ | ||
| <?php | ||
|
|
||
| namespace ExpressiveInstallerTest; | ||
|
|
||
| use Aura\Di\Container as AuraContainer; | ||
| use ExpressiveInstaller\OptionalPackages; | ||
| use Interop\Container\ContainerInterface; | ||
| use Interop\Container\Pimple\PimpleInterop as PimpleInteropContainer; | ||
| use Zend\Expressive; | ||
| use Zend\ServiceManager\ServiceManager as ZendServiceManagerContainer; | ||
|
|
||
| class ContainersTest extends InstallerTestCase | ||
| { | ||
| protected $teardownFiles = [ | ||
| '/config/container.php', | ||
| '/config/autoload/routes.global.php', | ||
| ]; | ||
|
|
||
| /** | ||
| * @dataProvider containerProvider | ||
| */ | ||
| public function testContainer( | ||
| $containerOption, | ||
| $routerOption, | ||
| $copyFilesKey, | ||
| $expectedResponseStatusCode, | ||
| $expectedContainer | ||
| ) { | ||
| // Install packages | ||
| $this->installPackage( | ||
| OptionalPackages::$config['questions']['container']['options'][$containerOption], | ||
| $copyFilesKey | ||
| ); | ||
| $this->installPackage( | ||
| OptionalPackages::$config['questions']['router']['options'][$routerOption], | ||
| $copyFilesKey | ||
| ); | ||
|
|
||
| // Test container | ||
| $container = $this->getContainer(); | ||
| $this->assertInstanceOf(ContainerInterface::class, $container); | ||
| $this->assertInstanceOf($expectedContainer, $container); | ||
| $this->assertTrue($container->has(Expressive\Helper\UrlHelper::class)); | ||
| $this->assertTrue($container->has(Expressive\Helper\ServerUrlHelper::class)); | ||
| $this->assertTrue($container->has(Expressive\Application::class)); | ||
| $this->assertTrue($container->has(Expressive\Router\RouterInterface::class)); | ||
|
|
||
| // Test home page | ||
| $response = $this->getAppResponse(); | ||
| $this->assertEquals($expectedResponseStatusCode, $response->getStatusCode()); | ||
| } | ||
|
|
||
| public function containerProvider() | ||
| { | ||
| // $containerOption, $routerOption, $copyFilesKey, $expectedResponseStatusCode, $expectedContainer | ||
| return [ | ||
| 'aura-minimal' => [1, 2, 'minimal-files', 404, AuraContainer::class], | ||
| 'aura-full' => [1, 2, 'copy-files', 200, AuraContainer::class], | ||
| 'pimple-minimal' => [2, 2, 'minimal-files', 404, PimpleInteropContainer::class], | ||
| 'pimple-full' => [2, 2, 'copy-files', 200, PimpleInteropContainer::class], | ||
| 'zend-sm-minimal' => [3, 2, 'minimal-files', 404, ZendServiceManagerContainer::class], | ||
| 'zend-sm-full' => [3, 2, 'copy-files', 200, ZendServiceManagerContainer::class], | ||
| ]; | ||
|
There was a problem hiding this comment. Please add keys to each, detailing what they are testing; this makes understanding which failed simpler: return [
'aura-full-install' => [ /* ... */ ],
'aura-minimal' => [/* ... */ ],
/* etc. */
]; |
||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,109 @@ | ||
| <?php | ||
|
|
||
| namespace ExpressiveInstallerTest; | ||
|
|
||
| use Composer\Factory; | ||
| use Composer\IO\IOInterface; | ||
| use Composer\Json\JsonFile; | ||
| use ExpressiveInstaller\OptionalPackages; | ||
| use Interop\Container\ContainerInterface; | ||
| use Prophecy\Argument; | ||
| use Psr\Http\Message\ResponseInterface; | ||
| use Zend\Diactoros\Response; | ||
| use Zend\Diactoros\ServerRequest; | ||
| use Zend\Expressive\Application; | ||
|
|
||
| class InstallerTestCase extends \PHPUnit_Framework_TestCase | ||
| { | ||
| /** | ||
| * @var IOInterface | ||
| */ | ||
| private $io; | ||
|
|
||
| private $projectRoot; | ||
|
|
||
| /** | ||
| * @var ContainerInterface | ||
| */ | ||
| protected $container; | ||
|
|
||
| protected $response; | ||
|
|
||
| protected $teardownFiles = []; | ||
|
|
||
| public function setup() | ||
| { | ||
| $this->response = null; | ||
|
|
||
| $this->cleanup(); | ||
|
|
||
| $this->io = $this->prophesize('Composer\IO\IOInterface'); | ||
|
|
||
| // Get composer.json | ||
| $composerFile = Factory::getComposerFile(); | ||
| $json = new JsonFile($composerFile); | ||
| OptionalPackages::$composerDefinition = $json->read(); | ||
|
|
||
| $this->projectRoot = realpath(dirname($composerFile)); | ||
|
|
||
| OptionalPackages::$config = require 'src/ExpressiveInstaller/config.php'; | ||
| } | ||
|
|
||
| public function tearDown() | ||
| { | ||
| parent::tearDown(); | ||
|
|
||
| $this->cleanup(); | ||
| } | ||
|
|
||
| public function installPackage($config, $copyFilesKey) | ||
| { | ||
| /* TODO: First we need to set $composerDefinition, $composerRequires, $composerDevRequires and $stabilityFlags; | ||
| // Add packages to install | ||
| if (isset($config['packages'])) { | ||
| foreach ($config['packages'] as $packageName) { | ||
| OptionalPackages::addPackage($this->io, $packageName, $this->config['packages'][$packageName]); | ||
| } | ||
| }*/ | ||
|
|
||
| // Copy files | ||
| if (isset($config[$copyFilesKey])) { | ||
| foreach ($config[$copyFilesKey] as $source => $target) { | ||
| OptionalPackages::copyFile($this->io->reveal(), $this->projectRoot, $source, $target); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| public function cleanup() | ||
| { | ||
| foreach ($this->teardownFiles as $file) { | ||
| if (is_file($this->projectRoot.$file)) { | ||
| unlink($this->projectRoot.$file); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| public function getContainer() | ||
| { | ||
| if (!$this->container) { | ||
| /** @var ContainerInterface $container */ | ||
| $this->container = require 'config/container.php'; | ||
| } | ||
|
|
||
| return $this->container; | ||
| } | ||
|
|
||
| public function getAppResponse($path = '/') | ||
| { | ||
| $container = $this->getContainer(); | ||
|
|
||
| /** @var Application $app */ | ||
| $app = $container->get('Zend\Expressive\Application'); | ||
| $request = new ServerRequest([], [], 'https://example.com'.$path, 'GET'); | ||
|
|
||
| /** @var ResponseInterface $response */ | ||
| $response = $app($request, new Response()); | ||
|
|
||
| return $response; | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why public?
If it's for testing, the various
assertAttribute*()assertions can do assertions on non-public properties. That said, I've not tried on static properties; if those present an issue, I'd argue reflection is still a better way to test these.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those are not being tested. They are public so I can set them from within a test. Doing it this way I don't need to repeat the code to setup the OptionalPackages class.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/zendframework/zend-expressive-skeleton/pull/48/files#diff-733c8720c49c759a0935fc5596c19e72R49
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couldn't these assignments be done with the Reflection API instead? That way we protect encapsulation for normal consumption.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure how this would work with static classes.