Use zend-stdlib for autoload config #7
Conversation
|
@xtreamwayz looks good. @weierophinney do we have any plan on how to test this sort of stuff? I think the change here is subtle, but VERY important. |
|
@xtreamwayz the |
|
@Ocramius That's what I was thinking myself. I've added the dependency. |
| @@ -11,7 +11,8 @@ | |||
| ], | |||
| "require": { | |||
| "roave/security-advisories": "dev-master", | |||
| "zendframework/zend-expressive": "^0.5" | |||
| "zendframework/zend-expressive": "^0.5", | |||
| "zendframework/zend-stdlib": "^2.7" | |||
There was a problem hiding this comment.
Can change it if you want. I used the same version as in zend-expressive.
There was a problem hiding this comment.
Use 2.7, as we don't need hydrators. ;-)
On Oct 11, 2015 2:54 PM, "Marco Pivetta" notifications@github.com wrote:
In composer.json
#7 (comment)
:@@ -11,7 +11,8 @@
],
"require": {
"roave/security-advisories": "dev-master",
"zendframework/zend-expressive": "^0.5""zendframework/zend-expressive": "^0.5","zendframework/zend-stdlib": "^2.7"Can rely on ~2.4 here, IMO.
—
Reply to this email directly or view it on GitHub
https://github.com/zendframework/zend-expressive-skeleton/pull/7/files#r41714643
.
There was a problem hiding this comment.
2.4 is the minimum supported version. By default composer will retireve the latest (2.7) so I don't see why bum the minimum so high.
Use zend-stdlib for autoload config
As discussed here: zendframework/zend-expressive#150
It fixes auto loading configuration files. This happens when routes are split in different files.
I'm not sure if zend-stdlib should be made a dependency since it is already included in zend-expressive.