This repository has been archived by the owner on Jan 30, 2020. It is now read-only.
Remove use of $GLOBALS['HTTP_RAW_POST_DATA'] #16
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -13,7 +13,7 @@ | |||
| } | |||
| }, | |||
| "require": { | |||
| "php": ">=5.5", | |||
| "php": ">=5.6", | |||
There was a problem hiding this comment.
this should be reverted.
There was a problem hiding this comment.
Ah, reading quickly through http://php.net/manual/en/wrappers.php.php#wrappers.php.input , I thought it was not available in <= PHP 5.5. I see I was mistaken. Thanks! I'll update.
|
Note: Prior to PHP 5.6, a stream opened with php://input could only be read once |
|
This change is a go now that minimum php version is bumped to 5.6 @RobLoach would you rebase and update tests that are dependent on |
|
Closing in favor of #74, which builds on this one, but updates the tests accordingly as well. |
weierophinney
added a commit
that referenced
this pull request
May 14, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10