This repository has been archived by the owner on Jan 30, 2020. It is now read-only.
Fix API reference to Writer->setFeedLinks() #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
setFeedLink() is the correct method
froschdesign
suggested changes
Jun 19, 2017
| @@ -210,7 +210,7 @@ Method | Description | |||
| `setTitle()` | Set the title of the feed. | |||
| `setDescription()` | Set the text description of the feed. | |||
| `setLink()` | Set a URI to the HTML website containing the same or similar information as this feed (i.e. if the feed is from a blog, it should provide the blog's URI where the HTML version of the entries can be read). | |||
| `setFeedLinks()` | Add a link to an XML feed, whether it is to the feed being generated, or an alternate URI pointing to the same feed but in a different format. At a minimum, it is recommended to include a link to the feed being generated so it has an identifiable final URI allowing a client to track its location changes without necessitating constant redirects. The parameter is an array of arrays, where each sub-array contains the keys "type" and "uri". The type should be one of "atom", "rss", or "rdf". | |||
There was a problem hiding this comment.
@elazar
Can you also check the table for Zend\Feed\Writer\Entry. There is the same wrong method included. Thanks!
froschdesign
approved these changes
Jun 20, 2017
weierophinney
added a commit
that referenced
this pull request
Nov 1, 2017
Fix API reference to Writer->setFeedLinks()
weierophinney
added a commit
that referenced
this pull request
Nov 1, 2017
|
Thanks, @elazar! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setFeedLink() is the correct method