Skip to content
This repository has been archived by the owner on Jan 30, 2020. It is now read-only.

Adds ext-dom and ext-libxml #91

Closed
wants to merge 2 commits into from
Closed

Adds ext-dom and ext-libxml #91

wants to merge 2 commits into from

Conversation

donatj
Copy link
Contributor

@donatj donatj commented Oct 25, 2018

Code very much requires ext-dom and ext-libxml, requirement is not noted in composer.

  • Are you fixing a bug?

    • Detail how the bug is invoked currently.
    • Detail the original, incorrect behavior.
    • Detail the new, expected behavior.
    • Base your feature on the master branch, and submit against that branch.
    • Add a regression test that demonstrates the bug, and proves the fix.
    • Add a CHANGELOG.md entry for the fix.
  • Are you creating a new feature?

    • Why is the new feature needed? What purpose does it serve?
    • How will users use the new feature?
    • Base your feature on the develop branch, and submit against that branch.
    • Add only one feature per pull request; split multiple features over multiple pull requests
    • Add tests for the new feature.
    • Add documentation for the new feature.
    • Add a CHANGELOG.md entry for the new feature.
  • Is this related to quality assurance?

  • Is this related to documentation?

@froschdesign froschdesign added this to the 2.10.0 milestone Nov 8, 2018
@weierophinney
Copy link
Member

Thanks, @donatj! Merged to develop for release with 2.11.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants