This repository has been archived by the owner on Jan 30, 2020. It is now read-only.
[BUG] An alias "filerename" was requested but no service could be found ZF2.5.3 #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buse974
changed the title
buse974
changed the title
|
This PR fix test suite with recent component. See (Fedora PHP Stack CI) https://apps.fedoraproject.org/koschei/package/php-zendframework-zend-file |
| @@ -18,6 +18,8 @@ | |||
| */ | |||
| class HttpTestMockAdapter extends Adapter\Http | |||
| { | |||
| static $aa = true; | |||
There was a problem hiding this comment.
Can this be given a better name?
weierophinney
added a commit
to weierophinney/zend-file
that referenced
this pull request
Feb 16, 2016
[BUG] An alias "filerename" was requested but no service could be found ZF2.5.3
weierophinney
added a commit
to weierophinney/zend-file
that referenced
this pull request
Feb 16, 2016
This patch incorporates feedback from zendframework#14, specifically: - Reverts the addition of zend-session to the requirements; it's not used anywhere. - Reverts changes to `HttpTestMockAdapter`; they did not serve any noticeable purpose. - Updates `AbstractAdapter` to cast the `$options` value to an array when scalar, ensuring it works with both v2 and v3 versions of zend-servicemanager. - Updated FilterPluginManager to: - Move the `array_merge()` option before the call to the parent constructor; this ensures any configuration passed at instantation takes precedence. - Use short array notation for the array passed to `array_merge()`. - Document the constructor. - Updated the `AbstractTest` - Reverted the change to `testAdapterShouldAllowPullingFiltersByFile`; it was changing the test to follow observed behavior instead of updating the code to retain existing behavior. - Fixed a number of CS issues with regards to multi-line arguments.
weierophinney
added a commit
that referenced
this pull request
Feb 16, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug with zend-filter 2.6.0 (ZF2.5.3)
Since version 2.6.0 of zend-filter the aliases property is used in Zend\Filter\FilterPluginManager. I merged aliases property in the constructor Zend\File\Transfer\Adapter\FilterPluginManager.
Here is a minimal example of the problem I ran into.
it works and tests pass.