This repository has been archived by the owner on Jan 30, 2020. It is now read-only.
Ensure progressbar tests can run #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since zend-progressbar is updated, it was time to test if the progressbar tests could run. The first hurdle was getting extensions installed; the second was discovering the tests as written could not work. To fix that, I separated them into discrete APC and UploadProgress tests. From there, I attempted to install the extensions and run each. As it turns out APC is uninstallable starting in PHP 5.5, so the APC tests cannot run regardless. I decided not to remove the support for now, on the off chance that people have figured out a workaround. The UploadProgress tests, however, required changes to the mock adapter to allow forcing error situations to occur. I can now verify they actually run and pass.
weierophinney
added a commit
that referenced
this pull request
Mar 2, 2016
weierophinney
added a commit
that referenced
this pull request
Mar 2, 2016
weierophinney
added a commit
that referenced
this pull request
Mar 2, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since zend-progressbar is updated, it was time to test if the progressbar tests could run. The first hurdle was getting extensions installed; the second was discovering the tests as written could not work.
To fix that, I separated them into discrete APC and UploadProgress tests. From there, I attempted to install the extensions and run each.
As it turns out APC is uninstallable starting in PHP 5.5, so the APC tests cannot run regardless. I decided not to remove the support for now, on the off chance that people have figured out a workaround.
The UploadProgress tests, however, required changes to the mock adapter to allow forcing error situations to occur. I can now verify they actually run and pass.