Skip to content
This repository has been archived by the owner on Jan 30, 2020. It is now read-only.

Fix: Drop HHVM from build matrix #40

Merged
merged 1 commit into from
Jun 3, 2017

Conversation

localheinz
Copy link
Member

@localheinz localheinz commented May 31, 2017

This PR

  • drops HHVM from the Travis build matrix

💁‍♂️ Somewhat related to #39 (comment), but on the other hand, a lot of projects are dropping HHVM, how about us?

@froschdesign
Copy link
Member

ping @weierophinney

Copy link
Member

@weierophinney weierophinney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. Most of our components no longer pass against HHVM due to usage of PHP features that HHVM has yet to implement. All stats I've seen lately indicate it's a miniscule segment of our user base. 👍 from me to remove.

@localheinz
Copy link
Member Author

Thank you, @froschdesign and @weierophinney!

@localheinz
Copy link
Member Author

@froschdesign @weierophinney

Ha, quick question, does this need a note in CHANGELOG.md, and if so, should this be targeted to a newer major version?

@froschdesign
Copy link
Member

@localheinz

…does this need a note in CHANGELOG.md

Good point. But with the background that the tests on Travis always allowed failures for HHVM, it should be a side note.

Perhaps by Twitter, blog post or community news, etc. – a place where we can refer. (ping @weierophinney)

…should this be targeted to a newer major version?

The same here, I see no need. With allowed failures it can be not an official support. (imo)

@localheinz
Copy link
Member Author

Thank you, @froschdesign!

@localheinz localheinz merged commit c42dcb2 into zendframework:develop Jun 3, 2017
@localheinz localheinz deleted the fix/hhvm branch June 3, 2017 09:27
@weierophinney
Copy link
Member

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants