This repository has been archived by the owner on Jan 30, 2020. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
ClassFileLocator
would enter a "function context" when it encounteredT_FUNCTION
token, causing it to ignore subsequent classes (thinking they are defined in a function), ultimately leading to the file being ignored becauseClassFileLocator
thought there's no (named) classes defined in the file.Now it will additionally check that the
T_FUNCTION
token is not preceded byT_USE
, fixing the bug.Steps to reproduce:
use function
(seeContainsUseFunction.php
in the test asset folder).ClassFileLocator
for a folder containing that fileExpected
The file should be found, and contain the class
Actual
The file is ignored
Checklist
master
branch, and submit against that branch.CHANGELOG.md
entry for the fix.