Merge branch 'hotfix/36'

Close #36
Fixes #35

CHANGELOG.md

@@ -23,6 +23,9 @@ All notable changes to this project will be documented in this file, in reverse
   ensuring it is injecting the relevant configuration from the `config` service
   and thus seeding it with configured translator loader services. This means
   that the `filters` configuration will now be honored in non-zend-mvc contexts.
+- [#36](https://github.com/zendframework/zend-filter/pull/36) fixes an issue in
+  the constructor whereby a discovered option was not removed from the options
+  list after being used to set the compression algorithm.
 
 ## 2.7.1 - 2016-04-18
 

src/Encrypt/Openssl.php

@@ -89,7 +89,7 @@ public function __construct($options = [])
 
         if (array_key_exists('compression', $options)) {
             $this->setCompression($options['compression']);
-            unset($options['compress']);
+            unset($options['compression']);
         }
 
         if (array_key_exists('package', $options)) {

test/Encrypt/OpensslTest.php

@@ -10,6 +10,7 @@
 namespace ZendTest\Filter\Encrypt;
 
 use PHPUnit\Framework\TestCase;
+use ReflectionProperty;
 use Zend\Filter\Encrypt\Openssl as OpensslEncryption;
 use Zend\Filter\Exception;
 
@@ -279,4 +280,15 @@ public function testEncryptionWithDecryptionAndCompressionWithPackagedKeys()
         $input = $filter->decrypt($output);
         $this->assertEquals('teststring', trim($input));
     }
+
+    public function testPassCompressionConfigWillBeUnsetCorrectly()
+    {
+        $filter = new OpensslEncryption([
+            'compression' => 'bz2',
+        ]);
+
+        $r = new ReflectionProperty($filter, 'keys');
+        $r->setAccessible(true);
+        $this->assertArrayNotHasKey('compression', $r->getValue($filter));
+    }
 }