Skip to content
This repository has been archived by the owner on Jan 30, 2020. It is now read-only.

Show target if file could not be renamed because the target file exists. #43

Merged
merged 2 commits into from
May 17, 2017

Conversation

wolxXx
Copy link
Contributor

@wolxXx wolxXx commented Sep 21, 2016

it was a little strange to know the source file but not the target file after uploading a file.
before: "File '/tmp/php9XZSCg' could not be renamed. It already exists."
after: "File '/tmp/php9XZSCg' could not be renamed to /new/path/fileName. It already exists."

thanks in advance.

it was a little strange to know the source file but not the target file after uploading a file. 
before: "File '/tmp/php9XZSCg' could not be renamed. It already exists."
after: "File '/tmp/php9XZSCg' could not be renamed to /new/path/fileName. It already exists."
@froschdesign
Copy link
Member

@wolxXx

"File '/tmp/php9XZSCg' could not be renamed to /new/path/fileName. It already exists."

Do you really want to show all your pathnames and also all non-public pathnames?!

@wolxXx
Copy link
Contributor Author

wolxXx commented Sep 21, 2016

yes. there is no usable information..
i want to know, what file could not be overwritten.
just knowing the name of the temporary file is useless.

@wolxXx
Copy link
Contributor Author

wolxXx commented Nov 8, 2016

any news here?

@wolxXx
Copy link
Contributor Author

wolxXx commented Feb 2, 2017

and now?

@weierophinney weierophinney added this to the 2.7.2 milestone May 17, 2017
@weierophinney weierophinney merged commit fe3d26e into zendframework:master May 17, 2017
weierophinney added a commit that referenced this pull request May 17, 2017
Show target if file could not be renamed because the target file exists.
weierophinney added a commit that referenced this pull request May 17, 2017
- Open `sprintf()` on same line as exception, and spread arguments one per
  line following
- Put quotes around each file name
- Indicate the _target_ file already exists in the message
- Do not end with punctuation
weierophinney added a commit that referenced this pull request May 17, 2017
weierophinney added a commit that referenced this pull request May 17, 2017
weierophinney added a commit that referenced this pull request May 17, 2017
@weierophinney
Copy link
Member

Thanks, @wolxXx

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants