This repository has been archived by the owner on Jan 30, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 35
Add StringPrefix filter with tests #69
Merged
weierophinney
merged 8 commits into
zendframework:develop
from
thexpand:string-prefix-suffix
Dec 12, 2018
Merged
Add StringPrefix filter with tests #69
weierophinney
merged 8 commits into
zendframework:develop
from
thexpand:string-prefix-suffix
Dec 12, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waltertamboer
suggested changes
Aug 16, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Except for the way of caling the assert methods, it all looks good to me.
froschdesign
suggested changes
Aug 18, 2018
thexpand
force-pushed
the
string-prefix-suffix
branch
from
September 5, 2018 12:36
2cfccef
to
6818a86
Compare
…ix/suffix filters
…nd suffix filters
weierophinney
added a commit
that referenced
this pull request
Dec 12, 2018
Add StringPrefix filter with tests
weierophinney
added a commit
that referenced
this pull request
Dec 12, 2018
- Modifies `$options` declaration to use `array<string, string|null>` for the type. - No parens needed around ternary statements as argument values. - Add space after casting operators.
weierophinney
added a commit
that referenced
this pull request
Dec 12, 2018
- Add names for each item in data providers. - Import all classes used.
weierophinney
added a commit
that referenced
this pull request
Dec 12, 2018
weierophinney
added a commit
that referenced
this pull request
Dec 12, 2018
Thanks, @thexpand! I have added documentation and merged for release! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#28