Updated Form class, bindValues function to set to empty array if no …

[rkeet]

Updated Form class, bindValues function to set to empty array if no data to pass along for baseFieldset

Provide a narrative description of what you are trying to accomplish:

• Are you fixing a bug?

In detail: #215

In short:

Form->bindValues($data, ...) calls Fieldset->bindValues($data, ...).

Fieldset has the function defined as:

public function bindValues(array $values = [], array $validationGroup = null)

The $data var was set with the following line:

$data = $data[$this->baseFieldset->getName()];

In the case of no defined Input elements, this may cause there to be no key with that name and have the $data variable be null. This then causes a fatal error when Form->bindValues($data, ...) calls Fieldset->bindValues($data, ...)

---

In respect, I've assumed that no tests need to be modified (they pass btw, though there's 40'ish that don't run because they're for Annotation) as this function was assumed to work with the happy-flow of properly calling the Fieldset->bindValues() function. This change just catches a bug but does not modify the intended functionality (I think).

[froschdesign]

@rkeet

In respect, I've assumed that no tests need to be modified

But we need an unit test to cover your scenario.

[rkeet]

Created a test case for the scenario. Am tired though, so please check it as well. More another day.

[froschdesign]

You can remove all these lines related to the input-filters. (830 - 835)
The result is the same.

[rkeet]

Done. Did indeed not make a difference for patch.

[froschdesign]

An unit test should be reduced to a minimum. The name for the form is not needed.

[rkeet]

Done

[froschdesign]

Please use $form->setHydrator(new Hydrator\ObjectProperty());

[weierophinney]

Both are imported, and there are examples of each in the test case. #224 resolves the consistency issues, so I'll leave as-is for now.

[weierophinney]

Thanks, @rkeet!