This repository has been archived by the owner on Jan 30, 2020. It is now read-only.
Fix rendering select element when value is an object #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Erikvv
commented
Aug 16, 2018
| @@ -285,7 +285,7 @@ protected function validateMultiValue($value, array $attributes) | |||
| } | |||
|
|
|||
| if (! is_array($value)) { | |||
| return (array) $value; | |||
| return [$value]; | |||
There was a problem hiding this comment.
The actual fix.
This line worked for string and int, creating an array with 1 element.
But for an object it will make an array of its properties and later on it will be treated like multiple values as if it's a multiselect.
weierophinney
added a commit
that referenced
this pull request
Dec 11, 2018
weierophinney
added a commit
that referenced
this pull request
Dec 11, 2018
|
Thanks, @Erikvv! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a select element with object as values (identifiers). The select element I believe is the only element which exhibits this behavior
The select element works when submitting, but it will not render a selected option as selected.
Select element works the same as using string values, relying on
__toString()