This repository was archived by the owner on Jan 30, 2020. It is now read-only.
Feature/http2 support #173
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsonasik
reviewed
Feb 14, 2019
Co-Authored-By: av3 <av3@users.noreply.github.com>
Need to indicate that HTTP/2 support is only available in 2.10.0 and up.
Extracts `validHttpVersions()` and `validResponseHttpVersionProvider()` methods to ensure we test various functionalities against each of the three supported HTTP versions. Updates `testResponseFactoryFromStringCreatesValidResponse()` to use the latter, and splits `testResponseCanRenderStatusLine()` into `testResponseCanRenderStatusLineUsingDefaultReasonPhrase()` and `testResponseCanRenderStatusLineUsingCustomReasonPhrase()`, each using `validHttpVersions()` as a data provider.
weierophinney
added a commit
that referenced
this pull request
Feb 19, 2019
- Updates branch aliases: - dev-master => 2.10.x-dev - dev-develop => 2.11.x-dev - Updates CHANGELOG: - Moves notes about #173 to 2.10.0 release - Sets date for 2.10.0 release - Removes empty stub for 2.9.2 release
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #172 there is currently no support for HTTP/2. I tried to fix it on my own and was able to process a HTTP/2 response. Hopefully this PR makes sense; I also added/extended unit tests and the documentation.