Skip to content
This repository was archived by the owner on Jan 30, 2020. It is now read-only.

All headers are case insensitive and should be treated as such to pre… #53

Closed
wants to merge 3 commits into from
Closed

All headers are case insensitive and should be treated as such to pre… #53

wants to merge 3 commits into from

Conversation

lucian303
Copy link
Contributor

@lucian303 lucian303 mentioned this pull request Mar 9, 2016
Closed
@Ocramius
Copy link
Member

Ocramius commented Mar 9, 2016

Missing tests

@Ocramius Ocramius added the bug label Mar 9, 2016
@lucian303
Copy link
Contributor Author

I wouldn't even know how to go about writing tests for this even if I had the time to. I guess until someone does, the Curl adapter will stay broken.

@GeeH GeeH mentioned this pull request Jun 28, 2016
Open
ezimuel added a commit to ezimuel/zend-http that referenced this pull request Aug 4, 2016
@ezimuel
Added the unit test for zendframework#53
871dda0
@ezimuel ezimuel mentioned this pull request Aug 4, 2016
Merged
@ezimuel
Copy link
Contributor

ezimuel commented Aug 4, 2016 •
edited
Loading

@lucian303 I sent a PR against your repository with the unit tests. /cc @Ocramius

@ezimuel ezimuel mentioned this pull request Aug 4, 2016
Closed
@ezimuel
Copy link
Contributor

ezimuel commented Aug 4, 2016

@lucian303 please merge lucian303#1 that adds the unit test for your PR.

@ezimuel ezimuel self-assigned this Aug 4, 2016
lucian303 added a commit to lucian303/zend-http that referenced this pull request Aug 4, 2016
@lucian303
Merge pull request #1 from ezimuel/lucian303-fix-case-sensitive-heade…
054019a 
…r-handling

Added the unit tests for PR zendframework#53
@ezimuel
Copy link
Contributor

ezimuel commented Aug 5, 2016

@lucian303 I'm sorry but I sent the PR against your master branch instead of the right one :( I re-sent the PR here, please merge again.

@lucian303
Copy link
Contributor Author

Yup, no problem.

On Fri, Aug 5, 2016 at 7:41 AM, Enrico Zimuel notifications@github.com
wrote:

@lucian303 https://github.com/lucian303 I'm sorry but I sent the PR
against your master branch instead of the right one :( I re-sent the PR
here lucian303#2, please merge again.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#53 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AARll7V6g_HYhzuZTQEgKPtim1mQ69w5ks5qc0uggaJpZM4HtGhe
.

@ezimuel
Copy link
Contributor

ezimuel commented Aug 8, 2016

Fixed CS issues during the merge in master/develop. Thanks to @lucian303 for the contribution!

@ezimuel ezimuel closed this Aug 8, 2016
@samsonasik samsonasik mentioned this pull request Jul 23, 2017
Closed
@weierophinney weierophinney mentioned this pull request Dec 31, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@ezimuel ezimuel

Labels
awaiting author updates bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lucian303 @Ocramius @ezimuel