Skip to content
This repository has been archived by the owner on Apr 28, 2020. It is now read-only.

Translations for portuguese from Portugal (pt_PT) #38

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

rolandoisidoro
Copy link

Captcha and Validate translations for portuguese from Portugal (pt_PT).

@froschdesign
Copy link
Member

We need another Portuguese speaking person to reviewing it. (Two-man rule)

@falsovsky
Copy link

Hi @froschdesign, I'm also Portuguese and I reviewed @rolandoisidoro translation. It seems good to merge to me!

@Xerkus Xerkus added this to the 2.7.0 milestone Jun 25, 2019
@Xerkus
Copy link
Member

Xerkus commented Jun 25, 2019

Sorry for the late reply.

There seem to be an issue with wrong translation keys used across all languages. This work probably have some of them too since you most likely used english provider as a source.
A work to get all the keys validated is quite time consuming which I lack at the moment.
As such I cannot proceed with merging and releasing this PR.

If someone can undertake the work to validate the keys in english provider and then implement tests to ensure there is no key mismatch between different languages, I will gladly review the work and make sure it is accepted promptly. At which point I will be able to accept this PR as well.

@weierophinney
Copy link
Member

This repository has been closed and moved to laminas/laminas-i18n-resources; a new issue has been opened at laminas/laminas-i18n-resources#3.

@weierophinney
Copy link
Member

This repository has been moved to laminas/laminas-i18n-resources. If you feel that this patch is still relevant, please re-open against that repository, and reference this issue. To re-open, we suggest the following workflow:

  • Squash all commits in your branch (git rebase -i origin/{branch})
  • Make a note of all changed files (`git diff --name-only origin/{branch}...HEAD
  • Run the laminas/laminas-migration tool on the code.
  • Clone laminas/laminas-i18n-resources to another directory.
  • Copy the files from the second bullet point to the clone of laminas/laminas-i18n-resources.
  • In your clone of laminas/laminas-i18n-resources, commit the files, push to your fork, and open the new PR.
    We will be providing tooling via laminas/laminas-migration soon to help automate the process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants