Skip to content
This repository has been archived by the owner on Jan 30, 2020. It is now read-only.

Commit

Permalink
Merge pull request zendframework/zendframework#6827 from hissy/no-plu…
Browse files Browse the repository at this point in the history
…ral-form-lang

Fix inability to translate to languages which don't have plural forms
  • Loading branch information
weierophinney committed Feb 24, 2015
180 parents a73339a + 171e486 + ba26b1d + ea0aebf + 63cc2ee + 740abb6 + 9b5478d + 91a23e2 + 8649d44 + 3f353b0 + d340adb + 1e0e8f4 + 5c4289e + fb94cca + 2a3844c + 906bbcf + 3d9b8bb + 84844ae + 62fc651 + b0a3dd4 + 0dca0ef + 910bbbf + e574b9b + f30ec7d + 1fa84de + 41b8543 + 9e2c9d5 + 913f51c + 39924f3 + c2a11e1 + 61b9322 + 413a38b + e51b2b8 + 20e328b + 6437ec0 + e9b8476 + 95e54a0 + 7ea3aed + df6a706 + a82fc82 + 7c2a059 + 4fefb53 + 599ee3a + ea3fc65 + f6c04c2 + 6591e3d + a4f76e3 + 33c7531 + 2d59782 + 8152327 + e56ce9b + db9b18f + b88635a + a262823 + b79aef6 + c2284e4 + 70193eb + 96acf77 + 9675426 + 5f02411 + 0dafea7 + 15dc674 + 4a2447d + e6eb7f3 + e9499c5 + 272b15f + 11c7758 + 6f0e918 + 5f4980a + ecca95a + 88b5971 + ecb8d13 + 9de1c08 + 44aad17 + 13269e9 + 654cdb6 + dc708db + 380ffba + ff67e7f + fe2e025 + 95f0efa + 68cc4b3 + bf13b96 + 8870381 + 56480f4 + 1fa90d7 + 5c7fe1f + abe9bc1 + a33cacd + cdd7d9f + 6a261b1 + 5e594c4 + 01c1241 + 30d1dd2 + d4af079 + c9aa9b4 + 10f47ca + ef20fa1 + 2187ae2 + e7f3993 + db93d37 + aa57612 + 4af81d8 + 2f90998 + 3013404 + 69d83fe + f383ca9 + 1b26f48 + 054f09d + 0c86829 + f22d81a + e7ebffe + 72a7a54 + cc09223 + ab99f58 + 2c69e37 + b6ccfbc + b92a5da + 773a133 + 9ee28ff + 5865e20 + 63c7303 + 73371d0 + b96f402 + b36e36b + 60fa081 + a1d27a6 + 43e9240 + 9e59ae6 + be1ce44 + 5a6465d + 7e455b4 + 83d837e + 28bc01e + 215be48 + efcc8e0 + 5192ae6 + 7e1ba0f + dec8ccf + 94afc0f + 8c3ea5f + d680762 + 9092473 + 041fc63 + ea6499d + 1f59300 + a75142b + f592cc2 + f523aef + 2d12221 + 34ad758 + 23cc229 + 1fa15a0 + 6b74fc7 + 44b0196 + 4cf13fa + 26a1d46 + 712a04b + 4dbc11a + c99b627 + 1472e82 + d816ccc + 7b26586 + 08d26c4 + a5cc444 + fe92acf + 6bd67b2 + 371ba41 + 2dc7154 + 2902dd7 + aecaa35 + fe40c59 + 434b5df + f231721 + e7d0a84 + 514fc95 + 92967e1 + 2069a1e + 0967d63 + affd8b7 commit c6179fc
Show file tree
Hide file tree
Showing 3 changed files with 37 additions and 0 deletions.
2 changes: 2 additions & 0 deletions src/Translator/Translator.php
Original file line number Diff line number Diff line change
Expand Up @@ -401,6 +401,8 @@ public function translatePlural(
}

return ($number == 1 ? $singular : $plural);
} elseif (is_string($translation)) {
$translation = array($translation);
}

$index = $this->messages[$textDomain][$locale]
Expand Down
20 changes: 20 additions & 0 deletions test/Translator/TranslatorTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -219,6 +219,26 @@ public function testTranslatePlurals()
$this->assertEquals('Message 5 (en) Plural 1', $pl1);
$this->assertEquals('Message 5 (en) Plural 2', $pl2);
}

public function testTranslateNoPlurals()
{
// Some languages such as Japanese and Chinese does not have plural forms
$this->translator->setLocale('ja_JP');
$this->translator->addTranslationFile(
'phparray',
$this->testFilesDir . '/testarray/translation-noplural-ja_JP.php',
'default',
'ja_JP'
);

$pl0 = $this->translator->translatePlural('Message 9', 'Message 9 Plural', 1);
$pl1 = $this->translator->translatePlural('Message 9', 'Message 9 Plural', 2);
$pl2 = $this->translator->translatePlural('Message 9', 'Message 9 Plural', 10);

$this->assertEquals('Message 9 (ja)', $pl0);
$this->assertEquals('Message 9 (ja)', $pl1);
$this->assertEquals('Message 9 (ja)', $pl2);
}

public function testTranslateNonExistantLocale()
{
Expand Down
15 changes: 15 additions & 0 deletions test/Translator/_files/testarray/translation-noplural-ja_JP.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
<?php
/**
* Zend Framework (http://framework.zend.com/)
*
* @link http://github.com/zendframework/zf2 for the canonical source repository
* @copyright Copyright (c) 2005-2014 Zend Technologies USA Inc. (http://www.zend.com)
* @license http://framework.zend.com/license/new-bsd New BSD License
*/

return array(
'' => array(
'plural_forms' => 'nplurals=1; plural=0;'
),
'Message 9' => 'Message 9 (ja)',
);

0 comments on commit c6179fc

Please sign in to comment.