Merge branch 'superdweebie-rand-bugfix'

composer.json

@@ -17,6 +17,12 @@
         "zendframework/zend-validator": "self.version",
         "zendframework/zend-stdlib": "self.version"
     },
+    "require-dev": {
+        "zendframework/zend-servicemanager": "self.version",
+        "fabpot/php-cs-fixer": "1.7.*",
+        "satooshi/php-coveralls": "dev-master",
+        "phpunit/PHPUnit": "~4.0"
+    },
     "suggest": {
         "zendframework/zend-servicemanager": "To support plugin manager support"
     },
@@ -31,10 +37,5 @@
         "psr-4": {
             "ZendTest\\InputFilter\\": "test/"
         }
-    },
-    "require-dev": {
-        "fabpot/php-cs-fixer": "1.7.*",
-        "satooshi/php-coveralls": "dev-master",
-        "phpunit/PHPUnit": "~4.0"
     }
 }

src/ArrayInput.php

@@ -56,8 +56,8 @@ public function isValid($context = null)
         foreach ($values as $value) {
             $result = $validator->isValid($value, $context);
             if (!$result) {
-                if ($fallbackValue = $this->getFallbackValue()) {
-                    $this->setValue($fallbackValue);
+                if ($this->hasFallback()) {
+                    $this->setValue($this->getFallbackValue());
                     $result = true;
                 }
                 break;

src/Input.php

@@ -70,6 +70,11 @@ class Input implements InputInterface, EmptyContextInterface
      */
     protected $fallbackValue;
 
+    /**
+     * @var bool
+     */
+    protected $hasFallback = false;
+
     public function __construct($name = null)
     {
         $this->name = $name;
@@ -173,6 +178,7 @@ public function setValue($value)
     public function setFallbackValue($value)
     {
         $this->fallbackValue = $value;
+        $this->hasFallback = true;
         return $this;
     }
 
@@ -271,6 +277,20 @@ public function getFallbackValue()
         return $this->fallbackValue;
     }
 
+    /**
+     * @return bool
+     */
+    public function hasFallback()
+    {
+        return $this->hasFallback;
+    }
+
+    public function clearFallbackValue()
+    {
+        $this->hasFallback = false;
+        $this->fallbackValue = null;
+    }
+
     /**
      * @param  InputInterface $input
      * @return Input
@@ -308,8 +328,8 @@ public function isValid($context = null)
         $validator = $this->getValidatorChain();
         $value     = $this->getValue();
         $result    = $validator->isValid($value, $context);
-        if (!$result && $fallbackValue = $this->getFallbackValue()) {
-            $this->setValue($fallbackValue);
+        if (!$result && $this->hasFallback()) {
+            $this->setValue($this->getFallbackValue());
             $result = true;
         }
 
@@ -325,7 +345,7 @@ public function getMessages()
             return (array) $this->errorMessage;
         }
 
-        if ($this->getFallbackValue()) {
+        if ($this->hasFallback()) {
             return array();
         }
 

test/ArrayInputTest.php

@@ -187,4 +187,37 @@ public function testDoNotInjectNotEmptyValidatorIfAnywhereInChain()
         $this->assertEquals(2, count($validators));
         $this->assertEquals($notEmptyMock, $validators[1]['instance']);
     }
+
+    public function dataFallbackValue()
+    {
+        return array(
+            array(
+                'fallbackValue' => array()
+            ),
+            array(
+                'fallbackValue' => array(''),
+            ),
+            array(
+                'fallbackValue' => array(null),
+            ),
+            array(
+                'fallbackValue' => array('some value'),
+            ),
+        );
+    }
+
+    /**
+     * @dataProvider dataFallbackValue
+     */
+    public function testFallbackValue($fallbackValue)
+    {
+        $this->input->setFallbackValue($fallbackValue);
+        $validator = new Validator\Date();
+        $this->input->getValidatorChain()->attach($validator);
+        $this->input->setValue(array('123')); // not a date
+
+        $this->assertTrue($this->input->isValid());
+        $this->assertEmpty($this->input->getMessages());
+        $this->assertSame($fallbackValue, $this->input->getValue());
+    }
 }

test/FileInputTest.php

@@ -340,4 +340,9 @@ public function testMerge()
         $filters = $filterChain->getFilters()->toArray();
         $this->assertInstanceOf('Zend\Filter\StringTrim', $filters[0]);
     }
+
+    public function testFallbackValue($fallbackValue = null)
+    {
+        $this->markTestSkipped('Not use fallback value');
+    }
 }

test/InputTest.php

@@ -273,6 +273,36 @@ public function testDoNotInjectNotEmptyValidatorIfAnywhereInChain()
         $this->assertEquals($notEmptyMock, $validators[1]['instance']);
     }
 
+    public function dataFallbackValue()
+    {
+        return array(
+            array(
+                'fallbackValue' => null
+            ),
+            array(
+                'fallbackValue' => ''
+            ),
+            array(
+                'fallbackValue' => 'some value'
+            ),
+        );
+    }
+
+    /**
+     * @dataProvider dataFallbackValue
+     */
+    public function testFallbackValue($fallbackValue)
+    {
+        $this->input->setFallbackValue($fallbackValue);
+        $validator = new Validator\Date();
+        $this->input->getValidatorChain()->attach($validator);
+        $this->input->setValue('123'); // not a date
+
+        $this->assertTrue($this->input->isValid());
+        $this->assertEmpty($this->input->getMessages());
+        $this->assertSame($fallbackValue, $this->input->getValue());
+    }
+
     public function testMergeRetainsContinueIfEmptyFlag()
     {
         $input = new Input('foo');