Skip to content
This repository has been archived by the owner on Jan 30, 2020. It is now read-only.

Commit

Permalink
Merge branch 'hotfix/5644'
Browse files Browse the repository at this point in the history
  • Loading branch information
weierophinney committed Mar 3, 2014
166 parents 09de2cd + e4898d7 + 9c57882 + 3c03bad + 87df75a + 89e1265 + 5bc0027 + 83fd9fa + 3844e27 + a2b3a39 + cbb5bf2 + 3ef3347 + bc77506 + e5e4203 + 2a10a27 + 8ba934c + 23ca50c + fd53025 + d95e884 + fb9734f + c781722 + a76fdf6 + 7f04465 + 3bc62a9 + f574eb9 + 52d314b + bada1dc + 842e034 + b44331a + 8d1b4e9 + 59d10c2 + e630f51 + 96f4abb + bfcf88b + e2e6ee0 + bd53446 + 62fffaa + 075b3a5 + dfc876b + 2056187 + ccaac9b + 5088038 + e4fa7ad + efc7cf5 + 0f33a2d + a3589c7 + 3ddf1a3 + d86b089 + 491f302 + c0efd18 + f9e572c + 3077af2 + a811b75 + 585f923 + 9b385ff + ec1f853 + b1a5d58 + a1cf97e + c1b8314 + 1482b41 + 7d80b85 + 869bbf8 + 403ce8d + 008804b + 87522da + d31ec42 + 2f2a15a + 585cc82 + a9438e2 + d59be1f + 643e2df + a49e8f2 + 08fd26d + b52d5dc + de5abc1 + 48f2d19 + 34ca3a0 + 5169094 + 25abd15 + baa09a1 + 355680a + b2b0d91 + 6986810 + 7b1513c + 6f9a6cc + 39a1c1e + 92dbdb3 + ac3a5aa + ee15c3a + 67f414a + 49138fb + a4ebc7b + 6b11637 + f128e27 + 41746af + cc083fe + 3d54828 + ccb0392 + a8ab5b0 + 1128b0c + b5ca6d2 + 5ef536e + 6878fa7 + 66a7225 + 869024d + 82f5ac4 + a831196 + dde75d7 + 9aba77c + 8474496 + 7c3bb76 + ad8e418 + a262925 + ee212be + 7f01229 + 42758bb + e91fa40 + 21394b2 + c56da7c + 9327465 + 95794f5 + 86491b5 + b24dc4f + 295467a + dc56d1e + d4c89e8 + ddd7418 + 8d06baa + ba834b9 + 292f809 + d235382 + 2b8ddfb + a90e617 + 8897e13 + 88b1391 + dc0450d + 9fa0112 + 7b9adef + 8010d61 + 8aa284d + d94ef71 + a3e5e8a + 6601fe6 + 6290724 + 5e7c801 + d74f16a + f3c55cf + f7787b1 + e1c3e3c + 88e1629 + 3314d9a + 09dfc28 + 6eac5f2 + aa1a1a6 + c602a92 + 9275250 + 11d2caa + d3c8400 + 295642a + bcf5cb7 + 1f38df6 + 5ea4665 + c66b1db + 7869e69 + 24907b1 + 35045bc commit a567ed5
Show file tree
Hide file tree
Showing 3 changed files with 43 additions and 3 deletions.
3 changes: 2 additions & 1 deletion src/Server/Smd.php
Original file line number Diff line number Diff line change
Expand Up @@ -373,11 +373,12 @@ public function toArray()
return $this->toDojoArray();
}

$description = $this->getDescription();
$transport = $this->getTransport();
$envelope = $this->getEnvelope();
$contentType = $this->getContentType();
$SMDVersion = static::SMD_VERSION;
$service = compact('transport', 'envelope', 'contentType', 'SMDVersion');
$service = compact('transport', 'envelope', 'contentType', 'SMDVersion', 'description');

if (null !== ($target = $this->getTarget())) {
$service['target'] = $target;
Expand Down
5 changes: 3 additions & 2 deletions src/Server/Smd/Service.php
Original file line number Diff line number Diff line change
Expand Up @@ -395,12 +395,13 @@ public function toArray()
$transport = $this->getTransport();
$parameters = $this->getParams();
$returns = $this->getReturn();
$name = $this->getName();

if (empty($target)) {
return compact('envelope', 'transport', 'parameters', 'returns');
return compact('envelope', 'transport', 'name', 'parameters', 'returns');
}

return $paramInfo = compact('envelope', 'target', 'transport', 'parameters', 'returns');
return compact('envelope', 'target', 'transport', 'name', 'parameters', 'returns');
}

/**
Expand Down
38 changes: 38 additions & 0 deletions test/Server/SmdTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -381,4 +381,42 @@ public function validateServiceArray(array $smd, array $options)
$this->assertTrue(array_key_exists('foo', $services));
$this->assertTrue(array_key_exists('bar', $services));
}

/**
* @group ZF2-5624
*/
public function testSetOptionsShouldAccommodateToArrayOutput()
{
$smdSource = new Smd();
$smdSource->setContentType('application/json');
$smdSource->setDescription('description');
$smdSource->setEnvelope(Smd::ENV_JSONRPC_1);
$smdSource->setId(uniqid());
$smdSource->setTarget('http://foo');
$smdSource->setTransport('POST');
$smdSource->setServices(array(
array('name' => 'foo')
));

$smdDestination = new Smd();
// prior to fix the following resulted in:
// .. Zend\Json\Server\Exception\InvalidArgumentException
// ... : SMD service description requires a name; none provided
$smdDestination->setOptions($smdSource->toArray());

$this->assertEquals($smdSource->getContentType(),
$smdDestination->getContentType());
$this->assertEquals($smdSource->getDescription(),
$smdDestination->getDescription());
$this->assertEquals($smdSource->getEnvelope(),
$smdDestination->getEnvelope());
$this->assertEquals($smdSource->getId(),
$smdDestination->getId());
$this->assertEquals($smdSource->getTarget(),
$smdDestination->getTarget());
$this->assertEquals($smdSource->getTransport(),
$smdDestination->getTransport());
$this->assertEquals($smdSource->getServices(),
$smdDestination->getServices());
}
}

0 comments on commit a567ed5

Please sign in to comment.