This repository has been archived by the owner on Jan 30, 2020. It is now read-only.
Expose package as a component and a config-provider #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds factories for the `ProcessorPluginManager` and `WriterPluginManager`, as previously exposed by zend-mvc. Tests were added to verify behavior.
…luginManager These should be handled like any other plugin managers!
Added: - `ConfigProvider`, which provides basic dependency configuration for each of the plugin managers, a `Logger` instance, and the abstract logger factory. - `Module`, which provides the above, but also provides specifications to the zend-modulemanager `ServiceListener` for configuring log filters, formatters, processors, and writers.
weierophinney
added a commit
that referenced
this pull request
Apr 6, 2016
weierophinney
added a commit
that referenced
this pull request
Apr 6, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added:
ProcessorPluginManagerFactoryandWriterPluginManagerFactoryimplementations, per their original implementation in zend-mvc.FilterPluginManagerFactoryandFormatterPluginManagerFactoryimplementations, for consistency within the component.ConfigProvider, which provides basic dependency configuration for each of the plugin managers, aLoggerinstance, and the abstract logger factory.Module, which provides the above, but also provides specifications to the zend-modulemanagerServiceListenerfor configuring log filters, formatters, processors, and writers.