-
Notifications
You must be signed in to change notification settings - Fork 111
can not create header object from certain inputs #64
Comments
problem can be mitigated by specifying long enough i've solved this in the past by calculating what the length may be. but current zend code doesn't even have charset parameters, so it could be anything whatever is current php version and php.ini settings. so, perhaps hardcode UTF-8 in that specific method and solve it similar way? i'll send PR (with test included) when i get some feedback. also i'm interested having this on 2.4 branch as well, i read LTS-WORKFLOW and seems the PR should be sent to zf2 repo for that? or maintainers will backport themselves? (the differences 2.4 vs 2.5 are rather in-existent, some array syntax changes only) |
backport for 2.4 Conflicts: src/Header/HeaderWrap.php
hallo? |
same issue as #33? we ran into this ourselves. |
looks same to me |
this case i even have bugfix, but no maintainer bothered to reply here, so never fired off the pull request the branch itself is here: |
No; we determine if a patch is a candidate, and backport it ourselves, as we have a very specific workflow for that. Right now, we're very conservative in what we backport, as the process is somewhat time-consuming, as well as brittle. Typical candidates are security fixes, and fixes for BC breaks introduced between 2.3 and 2.4. As such, this does not qualify. |
When trying to load raw (QP encoded, etc) headers with:
I came up to a problem that iconv_mime_encode can not be used reliably to validate if header can be encoded
for example (the value must be exactly like that):
the above code breaks at HeaderWrap::canBeEncoded when underlying
iconv_mime_encode
attempts to wordwrap the string and fails as it needs to wrap at middle of character or something:which results
false
as return value and InvalidArgumentException laterThe header will be encoded ok if the
$value
is lengthened or shortened even one byte before 76th character.The text was updated successfully, but these errors were encountered: