This repository has been archived by the owner on Jan 30, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 111
Protocol\Smtp: toggle QUIT>221 command at disconnect #117
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@Maks3w does the change sound applicable this way? |
Ping anyone? |
This looks good. I'll merge to develop for release with 2.8.0 (which will likely be a couple weeks, as there are a few other pending items that I'm waiting for author feedback on). I'll take care of the conflict during merge. |
weierophinney
added a commit
that referenced
this pull request
Feb 14, 2017
Protocol\Smtp: toggle QUIT>221 command at disconnect Conflicts: test/Protocol/SmtpTest.php
weierophinney
added a commit
that referenced
this pull request
Feb 14, 2017
weierophinney
added a commit
that referenced
this pull request
Feb 14, 2017
Merged to develop for release with 2.8.0. |
Slamdunk
added a commit
to Slamdunk/zend-mail
that referenced
this pull request
Feb 15, 2017
Slamdunk
added a commit
to Slamdunk/zend-mail
that referenced
this pull request
Feb 15, 2017
Here the doc against |
weierophinney
added a commit
that referenced
this pull request
Feb 15, 2017
Added documentation for #117
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original issue: #27
When a SMTP server implements a timeout, a script like this is a pain in the ass:
While the other features mentioned in #27 can be implemented in a custom way using OOP, this one cannot.
If a user wants to use
Protocol\Smtp
andProtocol\Smtp\Auth\Login
, the fact that:quit()
is hardcoded intoProtocol\Smtp::_disconnect()
Protocol\Smtp::_disconnect()
is hardcoded intoProtocol\AbstractProtocol::__destruct()
Makes impossible to customize zendframework/zend-mail component, even with subclassing, without rewriting the core code lines of
Zend\Protocol\*
With this PR a user can decide wether or not send the QUIT at __destruct / exit:
As soon as the PR is accepted, I'll PR to the doc.