This repository has been archived by the owner on Jan 30, 2020. It is now read-only.
added ext-iconv to require #128
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@samsonasik can you also bump the |
|
@Ocramius I think it was because of sebastianbergmann/comparator@9d9ede5 that fixed at sebastianbergmann/comparator@2b7424b that released yesterday . I am closing and re-open to restart build. |
|
@Ocramius travis green now ;) |
Ocramius
approved these changes
Jan 30, 2017
|
Assigning to 2.8.0 due to the new requirement. |
weierophinney
added a commit
that referenced
this pull request
Feb 14, 2017
added ext-iconv to require
weierophinney
added a commit
that referenced
this pull request
Feb 14, 2017
weierophinney
added a commit
that referenced
this pull request
Feb 14, 2017
|
Thanks, @samsonasik |
|
Merged to develop for release with 2.8.0 |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make it require in the first place to avoid user get error when using it: