This repository has been archived by the owner on Jan 30, 2020. It is now read-only.
unable to parse To headers with semicolon separator #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glensc
added a commit
to eventum/eventum
that referenced
this pull request
May 20, 2017
parser gives "The input exceeds the allowed length" error if headers are separated by semicolon zendframework/zend-mail#147 \Zend\Mail\Header\Exception\InvalidArgumentException extends \Zend\Mail\Exception\InvalidArgumentException so both exceptions covered
|
Your unit test is malformed. Instead of a failing assertion, an exception is being raised due to a line that is longer than allowed. Additionally, I'm not quite sure how to address this. The Please try and fix the unit test so that we know we're failing due to the |
|
the test case is written with "fixed" code in mind. it will pass if code behaves as expected. in other words, the code paths used should not throw, but it throws because it encounters different error (field too long) i don't see how you want this to be fixed or why. assertions are also exceptions internally. looks pointless eeb0031 the wrap is not needed once the code is fixed. |
|
@weierophinney requested changes are made altho i slightly disagree with them! |
weierophinney
force-pushed
the
address-semicolon-separator
branch
from
eeb0031 to
8ededca
Compare
weierophinney
added a commit
to eventum/zend-mail
that referenced
this pull request
Jun 6, 2018
This patch adds a new class, `AddressListParser`, with a single static method `parse()`. It loops through each character of the value to identify non-escaped, non-quoted delimiters, allowing either `,` or `;` to be used. `AbstractAddressList::fromString()` now uses the above method instead of `str_getcsv()` to extract the list of addresses. The patch also updates the test provided in zendframework#147 to test for the existence of all addresses in the test string.
weierophinney
added a commit
to eventum/zend-mail
that referenced
this pull request
Jun 6, 2018
Also removes stub for 3.0.0; master branch is targeted at 2.9.x-dev.
weierophinney
force-pushed
the
address-semicolon-separator
branch
from
c923715 to
1345849
Compare
weierophinney
added a commit
to eventum/zend-mail
that referenced
this pull request
Jun 6, 2018
This patch adds a new class, `AddressListParser`, with a single static method `parse()`. It loops through each character of the value to identify non-escaped, non-quoted delimiters, allowing either `,` or `;` to be used. `AbstractAddressList::fromString()` now uses the above method instead of `str_getcsv()` to extract the list of addresses. The patch also updates the test provided in zendframework#147 to test for the existence of all addresses in the test string.
weierophinney
added a commit
to eventum/zend-mail
that referenced
this pull request
Jun 6, 2018
Also removes stub for 3.0.0; master branch is targeted at 2.9.x-dev.
This patch adds a new class, `AddressListParser`, with a single static method `parse()`. It loops through each character of the value to identify non-escaped, non-quoted delimiters, allowing either `,` or `;` to be used. `AbstractAddressList::fromString()` now uses the above method instead of `str_getcsv()` to extract the list of addresses. The patch also updates the test provided in zendframework#147 to test for the existence of all addresses in the test string.
Also removes stub for 3.0.0; master branch is targeted at 2.9.x-dev.
weierophinney
force-pushed
the
address-semicolon-separator
branch
from
1345849 to
83f9dde
Compare
weierophinney
added a commit
that referenced
this pull request
Jun 6, 2018
weierophinney
added a commit
that referenced
this pull request
Jun 6, 2018
|
Thanks, @glensc, for the test; got a good fix in place now. |
glensc
added a commit
to eventum/zend-mail
that referenced
this pull request
Mar 4, 2019
silvadiego
pushed a commit
to silvadiego/zend-mail
that referenced
this pull request
Mar 20, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i wonder why Zend\Mail does not split on semicolon?
To: user1@domain.com; user2@domain.org. to my knowledge outlook sends out such mails: linkTo: undisclosed recipients:;. another examplethis PR adds testcase that should not fail