Skip to content
This repository has been archived by the owner on Jan 30, 2020. It is now read-only.

Add PHPDoc comments #171

Closed
wants to merge 1 commit into from
Closed

Add PHPDoc comments #171

wants to merge 1 commit into from

Conversation

danielabyan
Copy link
Contributor

In some cases, the IDE can not recognize the types of variables. To solve this problem, I've added comments in some places.
And I added comments for the following methods

  • Add missing comment for method GenericHeader::fromString
  • Add PHPDoc @return comment for Smtp::setUseCompleteQuit() method
  • PHPDoc @return comment does not apply to the constructor because remove this comment for Address::__construct
  • Add Mime\Message type for Mail\Message::$body property.

In some cases, the IDE can not recognize the types of variables. To solve this problem, I've added comments in some places.
And I added comments for the following methods
 - Add missing comment for method GenericHeader::fromString
 - Add PHPDoc @return comment for Smtp::setUseCompleteQuit() method
 - PHPDoc @return comment does not apply to the constructor because remove this comment for Address::__construct
 - Add Mime\Message type for Mail\Message::$body property.
@Ocramius Ocramius self-assigned this Mar 1, 2018
@Ocramius Ocramius added this to the 2.9.0 milestone Mar 1, 2018
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Ocramius added a commit that referenced this pull request Mar 1, 2018
@Ocramius
Copy link
Member

Ocramius commented Mar 1, 2018

@danielabyan thanks! Manually merged to 0c37b59

@Ocramius Ocramius closed this Mar 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants