This repository has been archived by the owner on Jan 30, 2020. It is now read-only.
Fix deprecated variant in idn_to_ascii #181
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In PHP 7.2, INTL_IDNA_VARIANT_2003 is deprecated in PHP Deprecated: idn_to_ascii(): INTL_IDNA_VARIANT_2003 is deprecated in zendframework\zend-mail\src\Header\AbstractAddressList.php on line 105
|
Thanks for contribution, but it's not enough as of yet. Are you able to do this (like zendframework/zend-validator#175)? Wanna try? If not, I can take care of this. |
vukanac
reviewed
Dec 20, 2017
src/Header/AbstractAddressList.php
Outdated
| @@ -102,7 +102,7 @@ public function getFieldName() | |||
| protected function idnToAscii($domainName) | |||
| { | |||
| if (extension_loaded('intl')) { | |||
| return (idn_to_ascii($domainName) ?: $domainName); | |||
| return (idn_to_ascii($domainName, 0, INTL_IDNA_VARIANT_UTS46) ?: $domainName); | |||
There was a problem hiding this comment.
if (extension_loaded('intl')) { if (defined('INTL_IDNA_VARIANT_UTS46')) { return (idn_to_ascii($email, 0, INTL_IDNA_VARIANT_UTS46) ?: $email); } return (idn_to_ascii($email) ?: $email); ...
|
Handled in #189 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PHP 7.2, INTL_IDNA_VARIANT_2003 is deprecated in
PHP Deprecated: idn_to_ascii(): INTL_IDNA_VARIANT_2003 is deprecated in zendframework\zend-mail\src\Header\AbstractAddressList.php on line 105
Reference issue: #177