This repository has been archived by the owner on Jan 30, 2020. It is now read-only.
Fix mail messages with blank line on top #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a data provider and compact assertions against current object state.
| @@ -42,6 +42,8 @@ public function __construct(array $params) | |||
| } else { | |||
| $params['raw'] = stream_get_contents($params['file']); | |||
| } | |||
|
|
|||
| $params['raw'] = ltrim($params['raw']); | |||
There was a problem hiding this comment.
Should apply the workaround always? (out of the if block)
|
Reading issue #19 seems this is not enough and another alternative should be provided. |
| $this->assertEquals('Peter Müller <peter-mueller@example.com>', $message->from); | ||
| } | ||
|
|
||
| public function testGetHeaderAsArray() |
There was a problem hiding this comment.
Having these as separate tests ensures that we can have granular tests for each behavior. Pushing all assertions into a single method makes identifying breakages harder, as the first assertion that fails causes any following assertions to never execute, which means we often end up playing whack-a-mole (fix one assertion, only to find the same test fails on an additional assertion). Please re-instate these discrete methods.
There was a problem hiding this comment.
I re-instated these when merging.
My reading of the two indicates they're completely separate issues. |
weierophinney
added a commit
that referenced
this pull request
Sep 9, 2015
Fix mail messages with blank line on top
weierophinney
added a commit
that referenced
this pull request
Sep 9, 2015
Re-instated each of: - testIsMultipart() - testGetHeader() - testGetDecodedHeader() - testGetHeaderAsArray() each with the `filesProvider` data provider; these replace the newly added `testParseFile()` in order to provide better granularity of assertions and behavior.
weierophinney
added a commit
that referenced
this pull request
Sep 9, 2015
weierophinney
added a commit
that referenced
this pull request
Sep 9, 2015
glensc
pushed a commit
to eventum/zend-mail
that referenced
this pull request
Feb 15, 2016
This commit backports changes from the 2.5 series for the 2.4.8 LTS release. These include the following: - [zendframework#11](zendframework#11) ensures that the sender can be a mailbox name, or an email specifying a host that omits the TLD. - [zendframework#21](zendframework#21) provides a patch to allow addresses in the form `Name address@domain.tld` (without angle brackets surrounding the actual email addres). - [zendframework#24](zendframework#24) fixes parsing of mail messagse that contain an initial blank line (prior to any headers), a situation observed in particular with GMail. - [zendframework#26](zendframework#26) fixes the `ContentType` header to properly handle parameters with encoded values.
weierophinney
added a commit
to zendframework/zendframework
that referenced
this pull request
Dec 20, 2016
This commit backports changes from the 2.5 series for the 2.4.8 LTS release. These include the following: - [#11](zendframework/zend-mail#11) ensures that the sender can be a mailbox name, or an email specifying a host that omits the TLD. - [#21](zendframework/zend-mail#21) provides a patch to allow addresses in the form `Name address@domain.tld` (without angle brackets surrounding the actual email addres). - [#24](zendframework/zend-mail#24) fixes parsing of mail messagse that contain an initial blank line (prior to any headers), a situation observed in particular with GMail. - [#26](zendframework/zend-mail#26) fixes the `ContentType` header to properly handle parameters with encoded values.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment of write this patch GMail (a popular mail provider) prepend mail messages with a line with whitespaces
This PR remove that line before parse.