Skip to content
This repository has been archived by the owner on Jan 30, 2020. It is now read-only.

Properly encode content-disposition header #251

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Properly encode content-disposition header #251

wants to merge 6 commits into from

Conversation

fredden
Copy link

@fredden fredden commented Dec 24, 2019

Provide a narrative description of what you are trying to accomplish:

  • Are you fixing a bug?
    • Detail how the bug is invoked currently.
    • Detail the original, incorrect behavior.
    • Detail the new, expected behavior.
    • Base your feature on the master branch, and submit against that branch.
    • Add a regression test that demonstrates the bug, and proves the fix.
    • Add a CHANGELOG.md entry for the fix.

Always use ASCII for the content-disposition header. When using UTF-8 encoding, this results in a header being set as Content-Disposition: =?utf-8?Q?inline?= which is not interpreted properly by Thunderbird nor Microsoft Exchange / Outlook. This pull request forces encoding for this header to always be ASCII, so that the header reads Content-Disposition: inline and is correctly interpreted by email clients.

Fixes: magento/magento2#25076

@fredden fredden changed the title Always encode content-disposition as ASCII Properly encode content-disposition header Dec 28, 2019
@weierophinney
Copy link
Member

This repository has been closed and moved to laminas/laminas-mail; a new issue has been opened at laminas/laminas-mail#2.

@weierophinney
Copy link
Member

This repository has been moved to laminas/laminas-mail. If you feel that this patch is still relevant, please re-open against that repository, and reference this issue. To re-open, we suggest the following workflow:

  • Squash all commits in your branch (git rebase -i origin/{branch})
  • Make a note of all changed files (`git diff --name-only origin/{branch}...HEAD
  • Run the laminas/laminas-migration tool on the code.
  • Clone laminas/laminas-mail to another directory.
  • Copy the files from the second bullet point to the clone of laminas/laminas-mail.
  • In your clone of laminas/laminas-mail, commit the files, push to your fork, and open the new PR.
    We will be providing tooling via laminas/laminas-migration soon to help automate the process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Magento 2.3.3 notifications converted to attachments in MS Exchange - Disposition Header
2 participants