This repository was archived by the owner on Jan 29, 2020. It is now read-only.
Fix issue with plugin manager detection in ServiceLocatorAware initializer #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lizer As reported in zendframework/zend-servicemanager#109, the "ServiceLocatorAware" initializer in zend-mvc breaks under the latest zend-servicemanager v2 versions due to mis-detection of the service container. Because both the SM instance itself and plugin managers implement `ContainerInterface`, the conditional used to detect a v3 variant of zend-servicemanager emits a false positive, as it falsely identifies the plugin manager as the service container. This patch adds an additional conditional, checking against specifically `AbstractPluginManager`, so that it can properly identify which argument is the container, and which is the instance to initialize.
weierophinney
added a commit
that referenced
this pull request
Apr 3, 2016
weierophinney
added a commit
that referenced
this pull request
Apr 3, 2016
weierophinney
added a commit
that referenced
this pull request
Apr 3, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in zendframework/zend-servicemanager#109, the "ServiceLocatorAware" initializer in zend-mvc breaks under the latest zend-servicemanager v2 versions due to mis-detection of the service container. Because both the SM instance itself and plugin managers implement
ContainerInterface, the conditional used to detect a v3 variant of zend-servicemanager emits a false positive, as it falsely identifies the plugin manager as the service container.This patch adds an additional conditional, checking against specifically
AbstractPluginManager, so that it can properly identify which argument is the container, and which is the instance to initialize.Fixes zendframework/zend-servicemanager#109