Skip to content
This repository was archived by the owner on Jan 29, 2020. It is now read-only.

Remove configureHelpers functionality from ViewHelperManager factory #125

Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 0 additions & 36 deletions src/Service/ViewHelperManagerFactory.php
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ class ViewHelperManagerFactory extends AbstractPluginManagerFactory
* @var array
*/
protected $defaultHelperMapClasses = [
'Zend\Navigation\View\HelperConfig',
];

/**
Expand All @@ -45,47 +44,12 @@ public function __invoke(ContainerInterface $container, $requestedName, array $o
$options['factories'] = isset($options['factories']) ? $options['factories'] : [];
$plugins = parent::__invoke($container, $requestedName, $options);

// Configure default helpers from other components
$plugins = $this->configureHelpers($plugins);

// Override plugin factories
$plugins = $this->injectOverrideFactories($plugins, $container);

return $plugins;
}

/**
* Configure helpers from other components.
*
* Loops through the list of default helper configuration classes, and uses
* each to configure the helper plugin manager.
*
* @param HelperPluginManager $plugins
* @return HelperPluginManager
*/
private function configureHelpers(HelperPluginManager $plugins)
{
foreach ($this->defaultHelperMapClasses as $configClass) {
if (! is_string($configClass) || ! class_exists($configClass)) {
continue;
}

$config = new $configClass();

if (! $config instanceof ConfigInterface) {
throw new ServiceNotCreatedException(sprintf(
'Invalid service manager configuration class provided; received "%s", expected class implementing %s',
$configClass,
ConfigInterface::class
));
}

$config->configureServiceManager($plugins);
}

return $plugins;
}

/**
* Inject override factories into the plugin manager.
*
Expand Down