This repository was archived by the owner on Jan 29, 2020. It is now read-only.
Better zend-servicemanager <-> zend-di integration deprecation #159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Per zendframework#125 - Also replaces fabpot/php-cs-fixer with friendsofphp/php-cs-fixer, per warnings during update (former is abandoned in favor of latter).
… v3 usage This patch reinstates the code removed in 2.7.9, and updates the docblocks to remove narrative indicating that they extend counterparts in zend-servicemanager-di. Additionally, the DiAbstractServiceFactoryFactory and DiServiceInitializerFactory were updated to raise exceptions if they detect that the relevant `Zend\ServiceManager\Di` artifacts are not present.
|
Visual inspection of code changes look good to me. |
weierophinney
added a commit
that referenced
this pull request
Jun 13, 2016
weierophinney
added a commit
that referenced
this pull request
Jun 13, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #125, requiring zend-servicemanager-di with zend-servicemanager v2 causes conflicts when creating an optimized autoloader with Composer. Unfortunately, the issue we're left with is:
Zend\ServiceManager\Dinamespace, which makes the various DI-related factories in zend-mvc result in fatal errors due to missing classes.The only viable solution is to re-instate the code removed in 2.7.9, but with the following changes:
DiAbstractServiceFactoryFactorynow checks to see ifZend\ServiceManager\Di\DiAbstractServiceFactoryexists, and, if not, raises an exception indicating the developer should install zend-servicemanager-di.DiServiceInitializerFactorynow checks to see ifZend\ServiceManager\Di\DiServiceInitializerexists, and, if not, raises an exception indicating the developer should install zend-servicemanager-di.Both of the above changes have unit tests for the new behavior introduced.
Additionally, all classes changed in 2.7.9 retain their deprecation annotations, signaling the change to come with zend-mvc v3.