This repository was archived by the owner on Jan 29, 2020. It is now read-only.

Fix: allow middleware dispatch to behave like controller dispatch#236

Merged

weierophinney merged 29 commits intozendframework:developfrom

Ocramius:fix/allow-middleware-dispatch-to-behave-like-controller-dispatch

May 1, 2017

Commits on May 1, 2017

`MiddlewareListener` should cancel any previous dispatch errors set in the given `MvcEvent`
Ocramius
committed
Removing route match mock - not needed
Ocramius
committed
Canceling previous `MvcEvent` errors when successfully dispatching a middleware
Ocramius
committed
Correcting assertion, since `MvcEvent#getError()` is always a `string`
Ocramius
committed
Verifying that the `MiddlewareListener` will relay anything the middleware produces, regardless of its shape/type, unless it is a PSR7-response
Ocramius
committed
Using a real service manager in the `MiddlewareListenerTest` - no test is mocking anything particular at this point
Ocramius
committed
Removed traditional `var_dump()` statement
Ocramius
committed
Creating an intermediate `MiddlewareController` that makes any middleware act like a normal controller
Ocramius
committed
Using the `MiddlewareListener` within the context of a `zend-mvc` dispatch
Ocramius
committed
A shared listener should be attached to middleware, so that the entire useless view layer can do its terrible view model magic
Ocramius
committed
Added missing docblock for a test class property
Ocramius
committed
The `MiddlewareListener` should bail out if an MVC result is already present in the dispatched event
Ocramius
committed
Skipping dispatch if an `MvcEvent#getResult()` is not null (fixes tests)
Ocramius
committed
Verifying that the `MiddlewareListener` triggers no error events on skipped dispatch
Ocramius
committed
The dispatch listener should not interfere when `MvcEvent#getResult()` already yields a non-null result
Ocramius
committed
Skipping dispatch when a non-null `MvcEvent#getResult()` is detected
Ocramius
committed
Corrected rebase conflicts - moved middleware pipe dispatch into the controller wrapper
Ocramius
committed
Optimised imports
Ocramius
committed
Removing unused callable parameters
Ocramius
committed
Splitting request attribute population into a private method
Ocramius
committed
Splitting request checks into their own method
Ocramius
committed
Removed unused imports
Ocramius
committed
Removing test that specifies that allowing anything as the return type of a middleware is OK
Ocramius
committed
Documenting the reason for the `MiddlewareController` to exist
Ocramius
committed
Basic test coverage for the `MiddlewareController`
Ocramius
committed
Dispatching a `MiddlewareController` with an invalid request type should raise a `RuntimeException`
Ocramius
committed
Removed unused imports
Ocramius
committed
Corrected `EventManagerInterface` type-hint
Ocramius
committed
CS (whitespace)
Ocramius
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix: allow middleware dispatch to behave like controller dispatch#236

Commits on May 1, 2017

`MiddlewareListener` should cancel any previous dispatch errors set in the given `MvcEvent`

Removing route match mock - not needed

Canceling previous `MvcEvent` errors when successfully dispatching a middleware

Correcting assertion, since `MvcEvent#getError()` is always a `string`

Verifying that the `MiddlewareListener` will relay anything the middleware produces, regardless of its shape/type, unless it is a PSR7-response

Using a real service manager in the `MiddlewareListenerTest` - no test is mocking anything particular at this point

Removed traditional `var_dump()` statement

Creating an intermediate `MiddlewareController` that makes any middleware act like a normal controller

Using the `MiddlewareListener` within the context of a `zend-mvc` dispatch

A shared listener should be attached to middleware, so that the entire useless view layer can do its terrible view model magic

Added missing docblock for a test class property

The `MiddlewareListener` should bail out if an MVC result is already present in the dispatched event

Skipping dispatch if an `MvcEvent#getResult()` is not null (fixes tests)

Verifying that the `MiddlewareListener` triggers no error events on skipped dispatch

The dispatch listener should not interfere when `MvcEvent#getResult()` already yields a non-null result

Skipping dispatch when a non-null `MvcEvent#getResult()` is detected

Corrected rebase conflicts - moved middleware pipe dispatch into the controller wrapper

Optimised imports

Removing unused callable parameters

Splitting request attribute population into a private method

Splitting request checks into their own method

Removed unused imports

Removing test that specifies that allowing anything as the return type of a middleware is OK

Documenting the reason for the `MiddlewareController` to exist

Basic test coverage for the `MiddlewareController`

Dispatching a `MiddlewareController` with an invalid request type should raise a `RuntimeException`

Removed unused imports

Corrected `EventManagerInterface` type-hint

CS (whitespace)