This repository was archived by the owner on Jan 29, 2020. It is now read-only.
Provide PHP 7.2 support for zend-mvc 2.7 series #279
Merged
+730
−526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
weierophinney
commented
May 2, 2018
weierophinney
commented
- Updates dependencies to versions known to work with 2.7 when possible.
- Fixes a signature within the PluginManager
- Fixes a test asset signature
- Adds 7.1 and 7.2 jobs
weierophinney
force-pushed
the
hotfix/2.7-php-7.2-support
branch
3 times, most recently
from
cb15aa2 to
7800a56
Compare
- Updates dependencies to versions known to work with 2.7 when possible. - Fixes a signature within the PluginManager - Fixes a test asset signature - Adds 7.1 and 7.2 jobs - Drops PHP 5.5 from the matrix Most dependencies _require_ 5.6 as a minimum supported version, and thus we cannot install dependencies as a result. It may still _work_ on 5.5, but if you're on 5.5, you don't care about 7.2 support. - Use latest possible version of PHPUnit in the v4 series.
…n detected `PluginManager` overrides the `get()` method, which has a different signature in v2 than in v3. Until PHP 7.2, this was not a problem; however, in 7.2, even optional values must follow the exact same signature as the parent. As a result, we now need to vary the implementations. This patch provides `AbstractPluginManager`, which contains the bulk of the logic for implementing the `PluginManager`. It then introduces the following: - `PluginManagerSM2`, which extends `AbstractPluginManager` and implements the zend-servicemanager v2 `get()` signature. - `PluginManagerSM3`, which extends `AbstractPluginManager` and implements the zend-servicemanager v3 `get()` signature. It removes the `PluginManager` class. It then adds a file-based autoloader that checks to see if `Zend\ServiceManager\PluginManagerInterface` exists. If it does, it aliases `PluginManager` to `PluginManagerSM3`; otherwise, it aliases it to `PluginManagerSM2`. Additionally, this patch updates to zend-servicemanager 2.7.10, which has important fixes to how it handles creation options with InvokableFactory that are necessary here.
weierophinney
force-pushed
the
hotfix/2.7-php-7.2-support
branch
from
7800a56 to
43cbba0
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.