Skip to content
This repository has been archived by the owner on Jan 29, 2020. It is now read-only.

Make use of class names instead of strings for services #292

Closed
wants to merge 7 commits into from
Closed

Make use of class names instead of strings for services #292

wants to merge 7 commits into from

Conversation

thexpand
Copy link
Contributor

Related to issue: #186

@thexpand
Copy link
Contributor Author

The Travis is failing on master, too. What can be done?

@geerteltink
Copy link
Member

@thexpand Travis is failing on all latest builds, meaning it tests against all of the latest dependencies. So you could probably run composer update locally and should see the tests fail as well. It makes it easier to find the package that causes the error and fix it. And then you can still decide if you want to include the updated composer file or not.

@thexpand thexpand changed the base branch from master to develop September 11, 2018 12:54
@thexpand
Copy link
Contributor Author

thexpand commented Sep 11, 2018 •
edited
Loading

@xtreamwayz I have created a hotfix for this as a new PR #293
We'll be able to continue with the current PR only after merging the hotfix. Can you make a code review?

@thexpand thexpand mentioned this pull request Sep 13, 2018
Open
@boesing
Copy link
Member

boesing commented Sep 17, 2018

As already wrote in #294, we should close this PR in favor of #294.
Fixes required for passing unit tests are provided with #295.

If we close this, we can drop a lot of confusion with those Pull Requests I guess.

@weierophinney weierophinney mentioned this pull request Dec 31, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
invalid
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@thexpand @geerteltink @boesing @froschdesign @Xerkus