This repository was archived by the owner on Jan 29, 2020. It is now read-only.
Url factory does not work starting in 2.6 #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch implements tests for each of the url, basepath, and doctype helpers, ensuring that the factory is invoked and the helper returned properly configured *for each alias* we define, as well as for the fully qualifed class name. Interestingly, while the basepath and doctype tests fail for every case, the URL helper only fails for the case of a fully qualified name; I'm hoping this will still work as a fix. I've refactored the `ViewHelperManagerFactory` substantially using the extract method refactor to extract: - helper factories (these are returned by dedicated methods now) - helper factory registration - helper configuration from other components In the case of the second bullet point, I am now registering the plugins using the FQCN as well as the normalized version of it, and not the aliases; the aliases will resolve to the factory name.
- normalize "config" service to lower case.
weierophinney
added a commit
that referenced
this pull request
Feb 22, 2016
weierophinney
added a commit
that referenced
this pull request
Feb 22, 2016
Close #71 Fixes zendframework/zend-view#51
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per zendframework/zend-view#51, the
urlfactory created inZend\Mvc\Service\ViewHelperManagerFaactoryno longer works as expected. The reason is becauseurlnow exists as an alias in the zend-viewHelperPluginManager, and aliases are resolved prior to attempting to pull the service.As such, the
ViewHelperManagerFactoryneeds to register the factory under the FQCN (as well as a normalized version of the FQCN) in order for it to be invoked (or it needs to override the alias).This also affects the basepath and doctype helpers.