Merge branch 'hotfix/29-performance-unset-resource'

Close #29
zendframework · May 1, 2018 · a0937e0 · a0937e0
2 parents 48d274e + 4e742dc
commit a0937e0
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 6 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -22,7 +22,7 @@ All notable changes to this project will be documented in this file, in reverse
 
 ### Fixed
 
-- Nothing.
+- [#29](https://github.com/zendframework/zend-permissions-acl/pull/29) provides a change to `Acl::removeResourceAll()` that increases performance by a factor of 100.
 
 ## 2.6.0 - 2016-02-03
 

diff --git a/src/Acl.php b/src/Acl.php
@@ -405,11 +405,7 @@ public function removeResource($resource)
     public function removeResourceAll()
     {
         foreach ($this->resources as $resourceId => $resource) {
-            foreach ($this->rules['byResourceId'] as $resourceIdCurrent => $rules) {
-                if ($resourceId === $resourceIdCurrent) {
-                    unset($this->rules['byResourceId'][$resourceIdCurrent]);
-                }
-            }
+            unset($this->rules['byResourceId'][$resourceId]);
         }
 
         $this->resources = [];