This repository has been archived by the owner on Jan 31, 2020. It is now read-only.
Promote to top-level namespace #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of using the original `Zend\Mvc\Router` namespace, this patch rewrites the component to use `Zend\Router` as the top-level namespace, mirroring the component name, and de-coupling it from zend-mvc. Additionally, it makes the decision that the component should only provide HTTP-based routing; an upcoming repository, zend-mvc-console, will contain all console-specific routing functionality. Finally, it removes deprecated functionality, specifically the Query route.
Import factories and related tests from zend-mvc ------------------------------------------------ The patch imports the existing service factories and tests for routing related services from zend-mvc, in preparation for making this a standalone module. Added ConfigProvider and Module classes --------------------------------------- Generic `ConfigProvider` for use with expressive-config-manager; provides dependency information, as well as expected key for `RoutePluginManager` configuration. `Module` for integration with zend-mvc. Returns configuration only at this time, and does so by calling on the `ConfigProvider`, and munging keys to suit zend-mvc-based applications.
weierophinney
added a commit
that referenced
this pull request
Mar 21, 2016
weierophinney
added a commit
that referenced
this pull request
Mar 21, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch is in preparation for a v3 release of zend-router, and accomplishes the following.
Top-level namespace
The namespace has been promoted from
Zend\Mvc\RoutertoZend\Router, and all classes updated accordingly.Removal of Console routes
Console routing has been removed (it will be in a forthcoming zend-mvc-console repository, which is currently in progress).
Removal of deprecated functionality
Deprecated functionality was removed, specifically the Query route.
Standalone component
This PR will supercede #1, and prepares the component to work standalone. This includes:
ConfigProviderclass for providing basic configuration (primarily dependency mapping); this is for use with expressive-config-manager and thus zend-expressive-zendrouter.Moduleclass with agetConfig()method that delegates toConfigProviderto provide zend-mvc-compatible configuration.Switching CS tooling
Finally, this patch also swaps php-cs-fixer for phpcs, and ensures all classes comply.