This repository has been archived by the owner on Feb 6, 2020. It is now read-only.
replace count() usage to empty() when possible #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsonasik
changed the title
Ocramius
suggested changes
Aug 10, 2017
src/Tool/ConfigDumperCommand.php
Outdated
| @@ -124,7 +124,7 @@ public function __invoke(array $args) | |||
| */ | |||
| private function parseArgs(array $args) | |||
| { | |||
| if (! count($args)) { | |||
| if (empty($args)) { | |||
There was a problem hiding this comment.
Can be replaced with if ($args) {
src/Tool/ConfigDumperCommand.php
Outdated
| @@ -140,7 +140,7 @@ private function parseArgs(array $args) | |||
| $arg1 = array_shift($args); | |||
| } | |||
|
|
|||
| if (! count($args)) { | |||
| if (empty($args)) { | |||
There was a problem hiding this comment.
Can be replaced with if ($args) {
src/Tool/FactoryCreatorCommand.php
Outdated
| @@ -104,7 +104,7 @@ public function __invoke(array $args) | |||
| */ | |||
| private function parseArgs(array $args) | |||
| { | |||
| if (! count($args)) { | |||
| if (empty($args)) { | |||
There was a problem hiding this comment.
Can be replaced with if ($args) {
|
@Ocramius I've updated |
|
LGTM 👍 |
Ocramius
approved these changes
Aug 10, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: http://maettig.com/code/php/php-performance-benchmarks.php#empty