This repository has been archived by the owner on Feb 6, 2020. It is now read-only.
ReflectionBasedAbstractFactory should not be expected to instantiate private constructors #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,7 +1,7 @@ | |||
| <?php | |||
| /** | |||
| * @link http://github.com/zendframework/zend-servicemanager for the canonical source repository | |||
| * @copyright Copyright (c) 2016 Zend Technologies USA Inc. (http://www.zend.com) | |||
| * @copyright Copyright (c) 2018 Zend Technologies USA Inc. (http://www.zend.com) | |||
| @@ -135,10 +135,27 @@ public function __invoke(ContainerInterface $container, $requestedName, array $o | |||
|
|
|||
| /** | |||
| * {@inheritDoc} | |||
| * @throws \ReflectionException | |||
There was a problem hiding this comment.
Hm... I know it could be thrown, but I don't think we should have it here.
|
|
||
| /** | ||
| * @param string $requestedName | ||
| * @return bool |
There was a problem hiding this comment.
Definitely we don't need two above doc-block comments, as these are duplicated with method signature.
The third one, yes, it's possible but as it is not throw explicitly I would remove it as well.
| @@ -1,7 +1,7 @@ | |||
| <?php | |||
| /** | |||
| * @link http://github.com/zendframework/zend-servicemanager for the canonical source repository | |||
| * @copyright Copyright (c) 2016 Zend Technologies USA Inc. (http://www.zend.com) | |||
| * @copyright Copyright (c) 2018 Zend Technologies USA Inc. (http://www.zend.com) | |||
| @@ -17,6 +17,8 @@ | |||
|
|
|||
| class ReflectionBasedAbstractFactoryTest extends TestCase | |||
| { | |||
| private $container; | |||
There was a problem hiding this comment.
Please add docblock:
/** @var ContainerInterface|ObjectProphecy $container */| @@ -38,6 +40,20 @@ public function testCanCreateReturnsFalseForNonClassRequestedNames($requestedNam | |||
| self::assertFalse($factory->canCreate($this->container->reveal(), $requestedName)); | |||
| } | |||
|
|
|||
| /** | |||
| * @throws \ReflectionException | |||
There was a problem hiding this comment.
No point of having it here.
asgrim
force-pushed
the
feature/ignore-private-constructors-reflection-abstract-factory
branch
from
5d1b0aa to
9e33889
Compare
|
@webimpress thanks for review! updated |
| return true; | ||
| } | ||
|
|
||
| return $constructor->isPublic(); |
There was a problem hiding this comment.
Could these be boiled down to:
return $constructor === null || $constructor->isPublic();?
| @@ -38,6 +42,17 @@ public function testCanCreateReturnsFalseForNonClassRequestedNames($requestedNam | |||
| self::assertFalse($factory->canCreate($this->container->reveal(), $requestedName)); | |||
| } | |||
|
|
|||
| public function testCanCreateReturnsFalseWhenConstructorIsPrivate() : void | |||
There was a problem hiding this comment.
It also looks like the new method would return true if no constructor is defined, correct? If so, that deserves its own test case.
There was a problem hiding this comment.
Correct; test case added
|
Can this be merged now @weierophinney |
|
Um... Bugfixes target **master**, features/improvements target develop; can
you clarify what you meant please, @Ocramius?
…On Fri, Dec 14, 2018, 6:39 AM Marco Pivetta ***@***.*** wrote:
@GeeH <https://github.com/GeeH> @asgrim <https://github.com/asgrim> we
need this to re-target develop, since it is a bug fix
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#268 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABlVxGhQyAss6hGv6NwxJpkcIGpaCnJks5u45vygaJpZM4T2hee>
.
|
|
|
…private constructors
Xerkus
force-pushed
the
feature/ignore-private-constructors-reflection-abstract-factory
branch
from
3026296 to
3378c43
Compare
Xerkus
added a commit
that referenced
this pull request
Dec 20, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that when using the
ReflectionBasedAbstractFactory, it chokes when classes withprivateconstructors are used. These types of classes should be ignored from the start, so I've updatedcanCreateto returnfalsewhere any class has aprivateconstructor.