This repository has been archived by the owner on Feb 6, 2020. It is now read-only.
Undefined $factory notice fix
#269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
demiankatz
force-pushed
the
undefined-factory-fix
branch
from
60d2409 to
cf703e8
Compare
malukenho
reviewed
Jun 22, 2018
| @@ -355,6 +355,8 @@ protected function createServiceViaCallback($callable, $cName, $rName) | |||
| } elseif (is_array($callable)) { | |||
| // reset both rewinds and returns the value of the first array element | |||
| $factory = reset($callable); | |||
| } else { | |||
| $factory = null; | |||
There was a problem hiding this comment.
Can't it be initialized as null first?
There was a problem hiding this comment.
Sure, just a question of style preference. I did it this way to avoid an unnecessary double-assignment, but if you prefer to trim a couple of lines by eliminating the else clause, that works fine too. I'll change it if you wish.
test/TestAsset/FooStaticFactory.php
Outdated
| * Zend Framework (http://framework.zend.com/) | ||
| * | ||
| * @link http://github.com/zendframework/zf2 for the canonical source repository | ||
| * @copyright Copyright (c) 2005-2015 Zend Technologies USA Inc. (http://www.zend.com) |
There was a problem hiding this comment.
Thanks -- fixed!
malukenho
approved these changes
Jun 22, 2018
|
Thanks @demiankatz! Released in |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a plugin manager uses a static class method as a factory (i.e.
FactoryClass::factoryMethod), as of release 2.7.10, it causes an undefined variable notice to be thrown due to an uncovered else case. This pull request provides a test case to demonstrate the problem as well as a fix. This problem does not appear to exist in the 3.x code, so it is presumably a side effect of backporting to 2.7. However, for projects depending on earlier versions of the service manager, it can be a significant problem and should be corrected -- that is why I am targeting this PR against the release-2.7 branch.