This repository has been archived by the owner on Feb 6, 2020. It is now read-only.
Forwards-compatibility changes #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch modifies the `AbstractPluginManager` constructor to allow the following combination of arguments: - No arguments (current behavior). - Single `ConfigInterface` argument (current behavior); used to configure the instance. - Single `ContainerInterface` argument (v3 behavior); sets the "parent" locator/"creation context" - `ContainerInterface` as first argument, array as second (v3 behavior); sets the "parent" locator/"creation context", and uses the second argument to configure the instance. These changes allow developers the ability to continue to use existing plugin managers when upgrading to v3 (though they will also need to implement a `validate()` method, which will be in the migration guide). The changes presented are backwards compatible (loosens typehint on initial argument; new, second argument is optional).
This was referenced Jan 5, 2016
Most of the component refactors are complete, and will need to be re-done. However, one item that should likely be retained is usage of the `InvokableFactory` for invokable instances. This patch adds that factory to the v2 series, having it implement `Zend\ServiceManager\FactoryInterface`, but retaining the defined invokable method from v3. It raises an exception if the `$requestedName` is not provided, ensuring that any tests against the functionality are using a `ServiceManager` instance.
akrabat
added a commit
that referenced
this pull request
Jan 8, 2016
akrabat
added a commit
that referenced
this pull request
Jan 8, 2016
|
Nicely done. Merged to master only as I'm pretty sure that it's not relevant to develop. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch provides forwards compatibility features for the v2 series to allow users to update their code for use with v3 prior to an actual migration.
AbstractPluginManager
This patch modifies the
AbstractPluginManagerconstructor to allow the following combination of arguments:ConfigInterfaceargument (current behavior); used to configure the instance.ContainerInterfaceargument (v3 behavior); sets the "parent" locator/"creation context"ContainerInterfaceas first argument, array as second (v3 behavior); sets the "parent" locator/"creation context", and uses the second argument to configure the instance.These changes allow developers the ability to continue to use existing plugin managers when upgrading to v3 (though they will also need to implement a
validate()method, which will be in the migration guide).The changes presented are backwards compatible (loosens typehint on initial argument; new, second argument is optional), and are based on changes being implemented in #59.
InvokableFactory
The
InvokableFactoryintroduced in the develop branch is compatible with v2 as well, and this patch adapts it for use with v2. This will allow existing component refactors to retain changes that introduce theInvokableFactory+ aliases.