Skip to content
This repository has been archived by the owner on Feb 6, 2020. It is now read-only.

fixed coveralls config #98

Closed

Conversation

svycka
Copy link
Contributor

@svycka svycka commented Feb 24, 2016

fixed coveralls config and restricted satooshi/php-coveralls to ^1.0 stable version

@svycka svycka force-pushed the hotfix/fix-coveralls-setup branch from 9cbb3f6 to 99fd0db Compare February 24, 2016 08:03
@svycka svycka mentioned this pull request Mar 6, 2016
@samsonasik
Copy link
Contributor

👍 yes, the src_dir config is not needed in latest php-coveralls ^1.0, another components needs to be updated as well

@samsonasik
Copy link
Contributor

@svycka would you mind to provide PR to other components as well ?

@svycka
Copy link
Contributor Author

svycka commented Mar 31, 2016

@samsonasik maybe, but just after this is merged because I don't know if there is everything ok.

@samsonasik
Copy link
Contributor

I used same approach for my personal repos, and that's how it works, see travis log

Warm regards,

Abdul Malik Ikhsan

Pada 31 Mar 2016, pukul 12.18, Vytautas Stankus notifications@github.com menulis:

@samsonasik maybe, but just after this is merged because I don't know if there is everything ok.


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub

@svycka
Copy link
Contributor Author

svycka commented Mar 31, 2016

@samsonasik I know it works but not sure zf team will approve it. Maybe they want to specify source folder or does not want -v option or something I don't know so I am waiting until this is merged.

@Ocramius Ocramius self-assigned this Jun 1, 2016
@Ocramius Ocramius added this to the 3.1.0 milestone Jun 1, 2016
Ocramius added a commit that referenced this pull request Jun 1, 2016
Ocramius added a commit that referenced this pull request Jun 1, 2016
@Ocramius
Copy link
Member

Ocramius commented Jun 1, 2016

@svycka thanks, included into 3.1.0 via 8129d6e

@Ocramius Ocramius closed this Jun 1, 2016
@svycka svycka deleted the hotfix/fix-coveralls-setup branch September 2, 2016 06:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants